Skip to content

Commit 379303d

Browse files
refactor(icon): remove ícones depreciados
Remove todos os usos das classes CSS: 'po-icon' e '.an', além da biblioteca PoIcon nos módulos PO-STYLE, PO-ANGULAR e PO-THEME-TOTVS. Elimina estilos, testes e documentação ligados aos ícones depreciados. Fixes DTHFUI-11345 BREAKING CHANGE: as classes po-icon e an foram removidas. Todos os componentes devem usar Animalia Icons como fonte padrão. Antes: <po-input p-icon='po-icon po-icon-anchor' p-label='PO input'></po-input> Depois: <po-input p-icon='an an-anchor' p-label='PO input'></po-input>
1 parent eb6c052 commit 379303d

File tree

48 files changed

+201
-522
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+201
-522
lines changed

docs/guides/deprecations.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
## Descontinuidade
88

9-
Anunciamos os recursos obsoletos no nosso [CHANGELOG](https://github.com/po-ui/po-angular/blob/master/CHANGELOG.md). Esses recursos obsoletos aparecem na documentação com uma marcação de *`Deprecated`* e não são mais exemplificados nos *samples* do portal. Quando anunciamos uma suspensão de uso, sempre anunciamos também um caminho de atualização recomendado. Neste documento teremos um resumo dessses recursos depreciados.
9+
Anunciamos os recursos obsoletos no nosso [CHANGELOG](https://github.com/po-ui/po-angular/blob/master/CHANGELOG.md). Esses recursos obsoletos aparecem na documentação com uma marcação de *`Deprecated`* e não são mais exemplificados nos *samples* do portal. Quando anunciamos uma suspensão de uso, sempre anunciamos também um caminho de atualização recomendado. Neste documento teremos um resumo desses recursos depreciados.
1010

1111
Quando um recurso é descontinuado ele ainda se mantém presente geralmente pelas próximas `duas` versões principais. Depois disso esses recursos serão removidos. Uma descontinuação pode ser anunciada em qualquer versão, mas a sua remoção acontecerá apenas na versão principal. Até um recurso depreciado ser removido, manteremos o suporte a problemas críticos e de segurança e também temos ferramentas de migração que geralmente automatizam a maior parte das atualizações.
1212

@@ -192,6 +192,22 @@ export class AppModule { }
192192
193193
```
194194

195+
### Remoção da biblioteca POIcon
196+
A partir da v20, a biblioteca de ícones POIcon foi removida. O conjunto padrão de ícones passa a ser a lib Animalia Icons.
197+
198+
Antes - PO Icon (legado)
199+
```
200+
//html
201+
<i class="po-icon po-icon-user"></i>
202+
```
203+
204+
Depois - Animalia Icons (atual)
205+
```
206+
//html
207+
<i class="an an-user"></i>
208+
```
209+
> Para saber como utilizar, veja em [Biblioteca de ícones](/icons) do PO UI.
210+
195211
## Breaking Changes
196212

197213
<div class="po-row">
@@ -224,6 +240,12 @@ export class AppModule { }
224240
<td class="po-table-column">p-helper</td>
225241
<td class="po-table-column" style="text-align: center;">v23</td>
226242
</tr>
243+
<tr class="po-table-row">
244+
<th class="po-table-column"><a href="/icons">POIcon</a></th>
245+
<td class="po-table-column">Biblioteca de ícones</td>
246+
<td class="po-table-column">Animalia Icons</td>
247+
<td class="po-table-column" style="text-align: center;">v20</td>
248+
</tr>
227249
<tr class="po-table-row">
228250
<th class="po-table-column"><a href="documentation/po-tabs">PoTabs</a></th>
229251
<td class="po-table-column">p-small</td>

projects/portal/src/app/icons/icons.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252
<div class="container">
5353
<div class="container-item po-pb-2">
5454
<p class="constructor-subtitle">
55-
Deprecated v20.x.x . A Biblioteca de ícones POIcon está depreciada e será removida na v20. Recomendamos o
56-
uso da Lib Animalia Icons conforme documentação abaixo
55+
A Biblioteca de ícones POIcon está depreciada e foi removida na v20.x.x. Recomendamos o uso da Lib Animalia
56+
Icons conforme documentação abaixo:
5757
</p>
5858
</div>
5959
</div>

projects/portal/src/app/theme-builder/theme-builder.component.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@ p {
473473
background-color: var(--background-hover);
474474
}
475475

476-
.combo-hover .po-combo-container-content span.po-field-icon.po-icon.po-icon-arrow-down.po-icon-input {
476+
.combo-hover .po-combo-container-content po-icon.po-field-icon i.an-caret-down.po-icon-input {
477477
border-color: var(--color-hover);
478478
background: var(--background-hover);
479479
}
@@ -486,8 +486,8 @@ p {
486486
outline-offset: 2px;
487487
}
488488

489-
.combo-focus .po-combo-input ~ .po-field-icon-container-right .po-field-icon.po-icon.po-icon-arrow-down,
490-
.combo-focus .po-combo-input ~ .po-field-icon-container-right .po-field-icon.po-icon.po-icon-arrow-up {
489+
.combo-focus .po-combo-input ~ .po-field-icon-container-right po-icon.po-field-icon i.an-caret-down.po-icon-input,
490+
.combo-focus .po-combo-input ~ .po-field-icon-container-right po-icon.po-field-icon i.an-caret-up.po-icon-input {
491491
border-color: var(--color-focused);
492492
}
493493

projects/portal/src/app/theme-builder/theme-builder.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@
939939
@if (!verifyIfItemVisibility()) {
940940
<po-widget class="po-lg-12 po-pr-0 po-pl-0 po-pb-2">
941941
<div class="container widget-align">
942-
<span class="po-icon po-icon-info"></span>
942+
<span class="an an-info"></span>
943943
<h2 class="po-ml-2">Nenhum componente selecionado</h2>
944944
</div>
945945
</po-widget>

projects/templates/src/lib/components/po-page-change-password/po-page-change-password.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
@for (requirement of requirements; track requirement) {
8989
<li class="po-page-change-password-required-item">
9090
<po-icon
91-
class="po-icon po-page-change-password-required-icon"
91+
class="po-page-change-password-required-icon"
9292
[p-icon]="
9393
validateRequirement(requirement)
9494
? 'ICON_OK po-page-change-password-required-ok'

projects/ui/src/lib/components/po-accordion/po-accordion-item-header/po-accordion-item-header.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@
1414
<po-tag class="po-accordion-item-header-tag" [p-value]="labelTag" [p-type]="typeTag"> </po-tag>
1515
}
1616
</div>
17-
<po-icon p-icon="ICON_ARROW_DOWN" class="po-icon po-accordion-item-header-icon"></po-icon>
17+
<po-icon p-icon="ICON_ARROW_DOWN" class="po-accordion-item-header-icon"></po-icon>
1818
</button>
1919
</div>

projects/ui/src/lib/components/po-accordion/po-accordion-item-header/po-accordion-item-header.component.spec.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,12 @@ describe('PoAccordionItemHeaderComponent:', () => {
9393
expect(button.querySelector('po-icon')).toBeTruthy();
9494
});
9595

96-
it('should have a icon with class po-icon', () => {
97-
expect(icon.classList.contains('po-icon')).toBeTruthy();
96+
it('should render the accordion icon using Animalia classes', () => {
97+
component.label = 'Accordion 1';
98+
fixture.detectChanges();
99+
100+
const icon = nativeElement.querySelector('po-icon i.an');
101+
expect(icon).toBeTruthy();
98102
});
99103

100104
it('should have a icon with class po-accordion-item-header-icon', () => {

projects/ui/src/lib/components/po-accordion/po-accordion-manager/po-accordion-manager.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<po-icon
1414
p-icon="ICON_LAST_PAGE"
1515
[ngClass]="expandedAllItems ? 'icon-down' : 'icon-up'"
16-
class="po-icon po-accordion-manager-icon"
16+
class="po-accordion-manager-icon"
1717
>
1818
</po-icon>
1919
</button>

projects/ui/src/lib/components/po-button/po-button.component.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe('PoButtonComponent: ', () => {
3737
expect(nativeElement.querySelector('.po-button-danger')).toBeFalsy();
3838
expect(nativeElement.querySelector('.po-button-link')).toBeFalsy();
3939

40-
expect(nativeElement.querySelector('span.po-icon')).toBeFalsy();
40+
expect(nativeElement.querySelector('po-icon i.an')).toBeFalsy();
4141
});
4242

4343
it('should update `p-label`', () => {
@@ -47,11 +47,12 @@ describe('PoButtonComponent: ', () => {
4747
expect(nativeElement.querySelector('.po-button-label').innerHTML).toContain('Po Button');
4848
});
4949

50-
it('should add i with an icon when `p-icon` is defined', () => {
51-
fixture.componentRef.setInput('p-icon', 'po-icon-news');
50+
it('should render an icon element when p-icon is defined', () => {
51+
fixture.componentRef.setInput('p-icon', 'an-newspaper');
5252
fixture.detectChanges();
5353

54-
expect(nativeElement.querySelector('i.po-icon.po-icon-news')).toBeTruthy();
54+
const icon = nativeElement.querySelector('po-icon i');
55+
expect(icon).toBeTruthy();
5556
});
5657

5758
it('should simulate button blur.', () => {

projects/ui/src/lib/components/po-dynamic/po-dynamic-view/po-dynamic-view.component.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -491,15 +491,15 @@ describe('PoDynamicViewComponent:', () => {
491491
});
492492

493493
it(`should create 'po-tag' with icon if properties 'tag' and 'icon' contain values.`, () => {
494-
component.fields = [{ property: 'cpf', label: 'CPF', tag: true, icon: 'po-icon-ok' }];
494+
component.fields = [{ property: 'cpf', label: 'CPF', tag: true, icon: 'an-check' }];
495495

496496
component.ngOnChanges({
497497
fields: new SimpleChange(null, component.fields, true)
498498
});
499499

500500
fixture.detectChanges();
501501
expect(nativeElement.querySelector('po-tag')).toBeTruthy();
502-
expect(nativeElement.querySelector('.po-icon-ok')).toBeTruthy();
502+
expect(nativeElement.querySelector('.an-check')).toBeTruthy();
503503
});
504504

505505
it(`should create 'po-tag' without icon if 'tag' is true but 'icon' is not defined.`, () => {
@@ -512,7 +512,7 @@ describe('PoDynamicViewComponent:', () => {
512512
fixture.detectChanges();
513513

514514
expect(nativeElement.querySelector('po-tag')).toBeTruthy();
515-
expect(nativeElement.querySelector('.po-icon-ok')).toBeFalsy();
515+
expect(nativeElement.querySelector('.an-check')).toBeFalsy();
516516
});
517517

518518
it(`should create 'po-tag' with a custom color if 'tag' and 'color' properties contain values.`, () => {

0 commit comments

Comments
 (0)