Skip to content

Conversation

@swaminawale
Copy link

@swaminawale swaminawale commented Nov 8, 2023

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
This is new solution

Checklist

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

@aprildunnam
Copy link
Contributor

Thank you for your submission!
To move forward with the review and merging of your pull request, we kindly request that you update your PR in accordance with the Contribution Guidelines. Please ensure that you added the README file following the provided template, and added the source code as instructed.

Thank you!

@aprildunnam aprildunnam added the Needs Attention Something needs to be fixed with the PR before merging label Nov 13, 2023
@swaminawale
Copy link
Author

Hi @aprildunnam, Thank you for your response.
I have cross checked the things and updated the Readme.md file. Let me know if there are any further issues

Thank you

@swaminawale swaminawale reopened this Dec 21, 2023
@Katerina-Chernevskaya
Copy link
Contributor

Hi @swamisnawale,

Thank you for your sample!
However, I want to kindly ask you to follow all the guides that April posted before. It is crucial to add source code and check Readme file to meet all requirements. Without the source code, we can't build the solution and check it.

Thank you!

Regards,
Katerina Ch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Attention Something needs to be fixed with the PR before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants