Skip to content

Commit 4bd843d

Browse files
author
Raphaël Benitte
committed
Merge pull request #32 from nii236/feature/add_project_source_target_id
add assertions, add source and project ID to JSON, tests, and struct
2 parents 075b1b4 + 58d014f commit 4bd843d

File tree

3 files changed

+28
-19
lines changed

3 files changed

+28
-19
lines changed

merge_requests.go

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,24 @@ const (
1616
)
1717

1818
type MergeRequest struct {
19-
Id int `json:"id,omitempty"`
20-
Iid int `json:"iid,omitempty"`
21-
TargetBranch string `json:"target_branch,omitempty"`
22-
SourceBranch string `json:"source_branch,omitempty"`
23-
ProjectId int `json:"project_id,omitempty"`
24-
Title string `json:"title,omitempty"`
25-
State string `json:"state,omitempty"`
26-
CreatedAt string `json:"created_at,omitempty"`
27-
UpdatedAt string `json:"updated_at,omitempty"`
28-
Upvotes int `json:"upvotes,omitempty"`
29-
Downvotes int `json:"downvotes,omitempty"`
30-
Author *User `json:"author,omitempty"`
31-
Assignee *User `json:"assignee,omitempty"`
32-
Description string `json:"description,omitempty"`
33-
WorkInProgress bool `json:"work_in_progress,omitempty"`
34-
MergeStatus string `json:"merge_status,omitempty"`
19+
Id int `json:"id,omitempty"`
20+
Iid int `json:"iid,omitempty"`
21+
TargetBranch string `json:"target_branch,omitempty"`
22+
SourceBranch string `json:"source_branch,omitempty"`
23+
ProjectId int `json:"project_id,omitempty"`
24+
Title string `json:"title,omitempty"`
25+
State string `json:"state,omitempty"`
26+
CreatedAt string `json:"created_at,omitempty"`
27+
UpdatedAt string `json:"updated_at,omitempty"`
28+
Upvotes int `json:"upvotes,omitempty"`
29+
Downvotes int `json:"downvotes,omitempty"`
30+
Author *User `json:"author,omitempty"`
31+
Assignee *User `json:"assignee,omitempty"`
32+
Description string `json:"description,omitempty"`
33+
WorkInProgress bool `json:"work_in_progress,omitempty"`
34+
MergeStatus string `json:"merge_status,omitempty"`
35+
SourceProjectID string `json:"source_project_id,omitempty"`
36+
TargetProjectID string `json:"target_project_id,omitempty"`
3537
}
3638

3739
type ChangeItem struct {

merge_requests_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package gogitlab
22

33
import (
4-
"github.com/stretchr/testify/assert"
54
"testing"
5+
6+
"github.com/stretchr/testify/assert"
67
)
78

89
func TestProjectMergeRequests(t *testing.T) {
@@ -20,6 +21,9 @@ func TestProjectMergeRequest(t *testing.T) {
2021

2122
assert.Equal(t, err, nil)
2223
assert.Equal(t, mr.TargetBranch, "master")
24+
assert.Equal(t, mr.MergeStatus, "can_be_merged")
25+
assert.Equal(t, mr.SourceProjectID, "2")
26+
assert.Equal(t, mr.TargetProjectID, "3")
2327
defer ts.Close()
2428
}
2529

stubs/merge_requests/show.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
"state": "active",
2727
"created_at": "2012-04-29T08:46:00Z"
2828
},
29+
"source_project_id": "2",
30+
"target_project_id": "3",
2931
"description":"fixed login page css paddings",
30-
"work_in_progress": false
31-
}
32+
"work_in_progress": false,
33+
"merge_status": "can_be_merged"
34+
}

0 commit comments

Comments
 (0)