fixup tests

Author: nicolaskruchten

src/__mocks__/plotly.js

@@ -18,6 +18,14 @@ export default {
       state.gd.emit('plotly_afterplot');
     }, ASYNC_DELAY);
   }),
+  react: jest.fn(gd => {
+    state.gd = gd;
+    EventEmitter(state.gd);
+
+    setTimeout(() => {
+      state.gd.emit('plotly_afterplot');
+    }, ASYNC_DELAY);
+  }),
   relayout: jest.fn(gd => {
     state.gd = gd;
     setTimeout(() => {

src/__tests__/react-plotly.test.js

@@ -84,29 +84,14 @@ describe('<Plotly/>', () => {
           .catch(err => done.fail(err))
           .then(done);
       });
-
-      test('overrides the height when fit: true', done => {
-        createPlot({
-          layout: {width: 320, height: 240},
-          fit: true,
-        })
-          .then(() => {
-            expectPlotlyAPICall(Plotly.newPlot, {
-              layout: {width: 320, height: 240},
-            });
-          })
-          .catch(err => done.fail(err))
-          .then(done);
-      });
     });
 
     describe('plot updates', () => {
       test('updates data', done => {
         createPlot({
-          fit: true,
           layout: {width: 123, height: 456},
           onUpdate: once(() => {
-            expectPlotlyAPICall(Plotly.newPlot, {
+            expectPlotlyAPICall(Plotly.react, {
               data: [{x: [1, 2, 3]}],
               layout: {width: 123, height: 456},
             });
@@ -121,9 +106,8 @@ describe('<Plotly/>', () => {
 
       test('sets the title', done => {
         createPlot({
-          fit: false,
           onUpdate: once(() => {
-            expectPlotlyAPICall(Plotly.newPlot, {
+            expectPlotlyAPICall(Plotly.react, {
               layout: {title: 'test test'},
             });
             done();
@@ -138,7 +122,6 @@ describe('<Plotly/>', () => {
       test('revision counter', done => {
         var callCnt = 0;
         createPlot({
-          fit: false,
           revision: 0,
           onUpdate: () => {
             callCnt++;
@@ -173,62 +156,5 @@ describe('<Plotly/>', () => {
           .catch(err => done.fail(err));
       });
     });
-
-    describe('responding to window events', () => {
-      describe('with fit: true', () => {
-        test('does not call relayout on initialization', done => {
-          createPlot({
-            fit: true,
-            onRelayout: () => done.fail('Unexpected relayout event'),
-          })
-            .then(() => {
-              setTimeout(done, 20);
-            })
-            .catch(err => done.fail(err));
-        });
-
-        test('calls relayout on window resize when fit: true', done => {
-          let relayoutCnt = 0;
-          createPlot({
-            fit: true,
-            onRelayout: () => {
-              relayoutCnt++;
-              if (relayoutCnt === 1) {
-                setTimeout(done, 20);
-              }
-            },
-          })
-            .then(() => {
-              window.dispatchEvent(new Event('resize'));
-            })
-            .catch(err => done.fail(err));
-        });
-      });
-
-      describe('with fit: false', () => {
-        test('does not call relayout on init', done => {
-          createPlot({
-            fit: false,
-            onRelayout: () => done.fail('Unexpected relayout event'),
-          })
-            .then(() => {
-              setTimeout(done, 20);
-            })
-            .catch(err => done.fail(err));
-        });
-
-        test('does not call relayout on window resize', done => {
-          createPlot({
-            fit: false,
-            onRelayout: () => done.fail('Unexpected relayout event'),
-          })
-            .then(() => {
-              window.dispatchEvent(new Event('resize'));
-              setTimeout(done, 20);
-            })
-            .catch(err => done.fail(err));
-        });
-      });
-    });
   });
 });

src/factory.js

@@ -146,7 +146,10 @@ export default function plotComponentFactory(Plotly) {
 
     figureCallback(callback) {
       if (typeof callback === 'function') {
-        const {data, layout, _transitionData: {_frames: frames}} = this.el;
+        const {data, layout} = this.el;
+        const frames = this.el._transitionData
+          ? this.el._transitionData._frames
+          : null;
         const figure = {data, layout, frames}; // for extra clarity!
         callback(figure, this.el);
       }