__repr__ refinements

 - Remove keyword unpacking `**`.
   This is optional now that a dict can be passed to the constructor directly.
 - Remove literal properties (e.g. scatter.type). These are read-only and can't
   be specified in the constructor.

Author: jonmmease

plotly/basedatatypes.py

@@ -12,7 +12,7 @@
 from . import offline as pyo
 from _plotly_utils.basevalidators import (
     CompoundValidator, CompoundArrayValidator, BaseDataValidator,
-    BaseValidator
+    BaseValidator, LiteralValidator
 )
 from . import animation
 from .callbacks import (Points, BoxSelector, LassoSelector,
@@ -2734,7 +2734,7 @@ def _build_repr_for_class(props, class_name, parent_path_str=None):
             # complaint indent
             body = '   ' + pprint_res[1:-1].replace('\n', '\n   ')
 
-            repr_str = class_name + '(**{\n ' + body + '\n})'
+            repr_str = class_name + '({\n ' + body + '\n})'
 
         return repr_str
 
@@ -2743,8 +2743,18 @@ def __repr__(self):
         Customize object representation when displayed in the
         terminal/notebook
         """
+
+        # Get all properties
+        props = self._props if self._props is not None else {}
+
+        # Remove literals (These can't be specified in the constructor)
+        props = {p: v for p, v in props.items()
+                 if p in self._validators and
+                 not isinstance(self._validators[p], LiteralValidator)}
+
+        # Build repr string
         repr_str = BasePlotlyType._build_repr_for_class(
-            props=self._props if self._props is not None else {},
+            props=props,
             class_name=self.__class__.__name__,
             parent_path_str=self._parent_path_str)
 

plotly/tests/test_core/test_graph_objs/test_repr.py

@@ -13,7 +13,7 @@ def test_trace_repr(self):
                     'opacity': [e / N for e in range(N)]})
 
         expected = """\
-Scatter(**{
+Scatter({
     'marker': {'color': 'green',
                'opacity': [0.0, 0.01, 0.02, 0.03, 0.04, 0.05, 0.06, 0.07, 0.08,
                            0.09, 0.1, 0.11, 0.12, 0.13, 0.14, 0.15, 0.16, 0.17,
@@ -27,7 +27,6 @@ def test_trace_repr(self):
                            0.81, 0.82, 0.83, 0.84, 0.85, 0.86, 0.87, 0.88, 0.89,
                            0.9, 0.91, 0.92, 0.93, 0.94, 0.95, 0.96, 0.97, 0.98,
                            0.99]},
-    'type': 'scatter',
     'y': [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19,
           20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37,
           38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55,
@@ -45,10 +44,9 @@ def test_trace_repr_elided(self):
                     'opacity': [e / N for e in range(N)]})
 
         expected = """\
-Scatter(**{
+Scatter({
     'marker': {'color': 'green',
                'opacity': [0.0, 0.001, 0.002, ..., 0.997, 0.998, 0.999]},
-    'type': 'scatter',
     'y': [0, 1, 2, ..., 997, 998, 999]
 })"""
         self.assertEqual(scatt.__repr__(), expected)