last of non-blocking

Author: Kully

plotly/grid_objs/grid_objs.py

@@ -152,11 +152,10 @@ def __init__(self, columns_or_json, fid=None):
             if fid is None:
                 raise exceptions.PlotlyError(
                     "If you are manually converting a raw json/dict grid "
-                    "into a Grid instance, you must ensure that make "
-                    "'fid' is set to your file ID. This looks like "
-                    "'username:187'."
+                    "into a Grid instance, you must ensure that 'fid' is "
+                    "set to your file ID. This looks like 'username:187'."
                 )
-            # TODO: verify that fid is a correct fid if a string
+
             self.id = fid
 
             # check if 'cols' is a root key
@@ -195,7 +194,7 @@ def __init__(self, columns_or_json, fid=None):
                 )
             self._columns = ordered_columns
 
-            # fill in uids
+            # fill in column_ids
             for column in self:
                 column.id = self.id + ':' + columns_or_json['cols'][column.name]['uid']
 
@@ -262,19 +261,18 @@ def get_column_reference(self, column_name):
         Raises an error if the column name is not in the grid. Otherwise,
         returns the fid:uid pair, which may be the empty string.
         """
-        col_names = []
-        for column in self._columns:
-            col_names.append(column.name)
-
         column_id = None
         for column in self._columns:
             if column.name == column_name:
                 column_id = column.id
                 break
 
         if column_id is None:
+            col_names = []
+            for column in self._columns:
+                col_names.append(column.name)
             raise exceptions.PlotlyError(
                 "Whoops, that column name doesn't match any of the column "
-                "names in your grid. You must pick from {cols}".format(col_names)
+                "names in your grid. You must pick from {cols}".format(cols=col_names)
             )
         return column_id

plotly/plotly/plotly.py

@@ -1594,7 +1594,7 @@ def create_animations(figure, filename=None, sharing='public', auto_open=True):
         parsed_response = r.content
 
     if 'error' in r and r['error'] != '':
-        raise exceptions.PlotlyError(r['message'])
+        raise exceptions.PlotlyError(r['error'])
 
     if sharing == 'secret':
         web_url = (parsed_response['file']['web_url'][:-1] +
@@ -1615,7 +1615,7 @@ def icreate_animations(figure, filename=None, sharing='public', auto_open=False)
     This function is based off `plotly.plotly.iplot`. See `plotly.plotly.
     create_animations` Doc String for param descriptions.
     """
-    # TODO - create a wrapper for iplot and icreate_animations
+    # Still needs doing: create a wrapper for iplot and icreate_animations
     url = create_animations(figure, filename, sharing, auto_open)
 
     if isinstance(figure, dict):