incorrect use of mergeWith causing mutation to _fullLayout (#1204)

* Fix bug causing `_fullData` property to be modified in mergeWith operation

* Don't include function values in delta object creation

Author: jonmmease

js/src/Figure.js

@@ -870,7 +870,7 @@ var FigureView = widgets.DOMWidgetView.extend({
      *
      */
     getFullData: function () {
-        return _.mergeWith(this.el._fullData, this.el.data,
+        return _.mergeWith({}, this.el._fullData, this.el.data,
             fullMergeCustomizer)
     },
 
@@ -881,7 +881,7 @@ var FigureView = widgets.DOMWidgetView.extend({
      * necessary
      */
     getFullLayout: function () {
-        return _.mergeWith(this.el._fullLayout, this.el.layout,
+        return _.mergeWith({}, this.el._fullLayout, this.el.layout,
             fullMergeCustomizer);
     },
 
@@ -1836,8 +1836,10 @@ function createDeltaObject(fullObj, removeObj) {
                     // the special case handling of this method
                     res[p] = createDeltaObject(fullVal, {});
 
-                } else if (fullVal !== undefined) {
-                    // No recursion necessary, Just keep value from fullObj
+                } else if (fullVal !== undefined &&
+                    typeof fullVal !== 'function') {
+                    // No recursion necessary, Just keep value from fullObj.
+                    // But skip values with function type
                     res[p] = fullVal;
                 }
             }

plotlywidget/static/index.js

@@ -13371,7 +13371,7 @@ var FigureView = widgets.DOMWidgetView.extend({
      *
      */
     getFullData: function () {
-        return _.mergeWith(this.el._fullData, this.el.data,
+        return _.mergeWith({}, this.el._fullData, this.el.data,
             fullMergeCustomizer)
     },
 
@@ -13382,7 +13382,7 @@ var FigureView = widgets.DOMWidgetView.extend({
      * necessary
      */
     getFullLayout: function () {
-        return _.mergeWith(this.el._fullLayout, this.el.layout,
+        return _.mergeWith({}, this.el._fullLayout, this.el.layout,
             fullMergeCustomizer);
     },
 
@@ -14337,8 +14337,10 @@ function createDeltaObject(fullObj, removeObj) {
                     // the special case handling of this method
                     res[p] = createDeltaObject(fullVal, {});
 
-                } else if (fullVal !== undefined) {
-                    // No recursion necessary, Just keep value from fullObj
+                } else if (fullVal !== undefined &&
+                    typeof fullVal !== 'function') {
+                    // No recursion necessary, Just keep value from fullObj.
+                    // But skip values with function type
                     res[p] = fullVal;
                 }
             }