Prevent iplot from breaking when Jupyter notebook has headline named "Plotly" (#1250)

This PR works around the issue where a Jupyter Notebook heading
named "Plotly" clashes with the window.Plotly variable where we store
the plotly.js module.

The workaround is to name this variable the much less likely _Plotly

Author: jonmmease

plotly/offline/offline.py

@@ -204,9 +204,9 @@ def init_notebook_mode(connected=False):
             # Note we omit the extension .js because require will include it.
             '\'plotly\': [\'https://cdn.plot.ly/plotly-latest.min\']}},'
             '}});'
-            'if(!window.Plotly) {{'
+            'if(!window._Plotly) {{'
             'require([\'plotly\'],'
-            'function(plotly) {{window.Plotly=plotly;}});'
+            'function(plotly) {{window._Plotly=plotly;}});'
             '}}'
             '</script>'
         ).format(win_config=_window_plotly_config,
@@ -217,12 +217,12 @@ def init_notebook_mode(connected=False):
             '{win_config}'
             '{mathjax_config}'
             '<script type=\'text/javascript\'>'
-            'if(!window.Plotly){{'
+            'if(!window._Plotly){{'
             'define(\'plotly\', function(require, exports, module) {{'
             '{script}'
             '}});'
             'require([\'plotly\'], function(Plotly) {{'
-            'window.Plotly = Plotly;'
+            'window._Plotly = Plotly;'
             '}});'
             '}}'
             '</script>'

plotly/tests/test_optional/test_jupyter/js_tests/connected_false.js

@@ -24,7 +24,7 @@ test('should inject raw plotly.js code into DOM', function(t) {
     nodes = Array.prototype.slice.call(nodes, 0, 10);
 
     var results = nodes.filter(function(node) {
-        return node.innerHTML.substr(0, 19) === 'if(!window.Plotly){';
+        return node.innerHTML.substr(0, 20) === 'if(!window._Plotly){';
     });
 
     t.equal(results.length, 1);