Clean up

Author: ddworken

tests/test_core/test_offline/test_offline.py

@@ -9,8 +9,10 @@
 import pytest
 
 import plotly
+from plotly.offline import get_plotlyjs
 import plotly.io as pio
 from plotly.io._utils import plotly_cdn_url
+from plotly.io._html import _generate_sri_hash
 
 packages_root = os.path.dirname(
     os.path.dirname(os.path.dirname(os.path.dirname(os.path.realpath(plotly.__file__))))
@@ -37,7 +39,7 @@
 <script type="text/javascript">\
 window.PlotlyConfig = {MathJaxConfig: 'local'};</script>"""
 
-cdn_script = '<script charset="utf-8" src="{cdn_url}"'.format(cdn_url=plotly_cdn_url())
+cdn_script = '<script charset="utf-8" src="{cdn_url}" integrity="{js_hash}" crossorigin="anonymous"></script>'.format(cdn_url=plotly_cdn_url(), js_hash=_generate_sri_hash(get_plotlyjs()))
 
 directory_script = '<script charset="utf-8" src="plotly.min.js"></script>'
 

tests/test_io/test_html.py

@@ -2,6 +2,7 @@
 
 import pytest
 import numpy as np
+import re
 
 
 import plotly.graph_objs as go
@@ -59,8 +60,6 @@ def test_cdn_includes_integrity_attribute(fig1):
     assert 'crossorigin="anonymous"' in html_output
 
     # Verify it's in the correct script tag
-    import re
-
     cdn_pattern = re.compile(
         r'<script[^>]*src="'
         + re.escape(plotly_cdn_url())
@@ -75,8 +74,6 @@ def test_cdn_integrity_hash_matches_bundled_content(fig1):
     html_output = pio.to_html(fig1, include_plotlyjs="cdn")
 
     # Extract the integrity hash from the HTML output
-    import re
-
     integrity_pattern = re.compile(r'integrity="(sha256-[A-Za-z0-9+/=]+)"')
     match = integrity_pattern.search(html_output)
     assert match is not None, "Integrity attribute not found"