Support row or col in select_traces (not only supporting both)

Author: jonmmease

plotly/basedatatypes.py

@@ -666,26 +666,36 @@ def select_traces(self, selector=None, row=None, col=None):
         if not selector:
             selector = {}
 
-        if row is not None and col is not None:
+        if row is not None or col is not None:
             _validate_v4_subplots('select_traces')
             grid_ref = self._validate_get_grid_ref()
-            grid_subplot_ref = grid_ref[row-1][col-1]
             filter_by_subplot = True
+
+            if row is None:
+                # All rows for column
+                grid_subplot_refs = [ref_row[col-1] for ref_row in grid_ref]
+            elif col is None:
+                # All columns for row
+                grid_subplot_refs = grid_ref[row-1]
+            else:
+                # Single grid cell
+                grid_subplot_refs = [grid_ref[row-1][col-1]]
+
         else:
             filter_by_subplot = False
-            grid_subplot_ref = None
+            grid_subplot_refs = None
 
         return self._perform_select_traces(
-            filter_by_subplot, grid_subplot_ref, selector)
+            filter_by_subplot, grid_subplot_refs, selector)
 
     def _perform_select_traces(
-            self, filter_by_subplot, grid_subplot_ref, selector):
+            self, filter_by_subplot, grid_subplot_refs, selector):
 
         for trace in self.data:
             # Filter by subplot
             if filter_by_subplot:
                 trace_subplot_ref = _get_subplot_ref_for_trace(trace)
-                if grid_subplot_ref != trace_subplot_ref:
+                if trace_subplot_ref not in grid_subplot_refs:
                     continue
 
             # Filter by selector

plotly/tests/test_core/test_update_traces/test_update_traces.py renamed to plotly/tests/test_core/test_update_objects/test_update_traces.py

@@ -158,12 +158,22 @@ def test_select_by_type(self):
             [], selector={'type': 'pie'}, test_no_grid=True)
 
     def test_select_by_grid(self):
+        # Row and column
         self.assert_select_traces([0, 1], row=1, col=1)
         self.assert_select_traces([2, 3], row=2, col=1)
         self.assert_select_traces([4, 5], row=1, col=2)
         self.assert_select_traces([6, 7], row=2, col=2)
         self.assert_select_traces([8], row=3, col=1)
 
+        # Row only
+        self.assert_select_traces([0, 1, 4, 5], row=1)
+        self.assert_select_traces([2, 3, 6, 7], row=2)
+        self.assert_select_traces([8], row=3)
+
+        # Col only
+        self.assert_select_traces([0, 1, 2, 3, 8], col=1)
+        self.assert_select_traces([4, 5, 6, 7], col=2)
+
     def test_select_by_property_across_trace_types(self):
         self.assert_select_traces(
             [0, 4, 6], selector={'mode': 'markers'}, test_no_grid=True)
@@ -322,3 +332,25 @@ def test_update_traces_by_type(self):
             {'hoverinfo': 'label+percent'},
             [], selector={'type': 'pie'}
         )
+
+    def test_update_traces_by_grid_and_selector(self):
+        self.assert_update_traces(
+            {'marker.size': 5},
+            [4, 6],
+            selector={'marker.color': 'green'},
+            col=2
+        )
+
+        self.assert_update_traces(
+            {'marker.size': 6},
+            [0, 4],
+            selector={'marker.color': 'green'},
+            row=1
+        )
+
+        self.assert_update_traces(
+            {'marker.size': 6},
+            [6],
+            selector={'marker.color': 'green'},
+            row=2, col=2
+        )