test extra noise in category_orders

Author: nicolaskruchten

packages/python/plotly/plotly/tests/test_core/test_px/test_px.py

@@ -192,33 +192,44 @@ def test_orthogonal_orderings():
     symbol_sequence = ["circle", "diamond", "square", "cross"]
     color_sequence = ["red", "blue"]
 
+    def assert_orderings(days_order, days_check, times_order, times_check):
+        fig = px.scatter(
+            df,
+            x="total_bill",
+            y="tip",
+            facet_row="time",
+            facet_col="day",
+            color="time",
+            symbol="day",
+            symbol_sequence=symbol_sequence,
+            color_discrete_sequence=color_sequence,
+            category_orders=dict(day=days_order, time=times_order),
+        )
+
+        for col in range(len(days_check)):
+            for trace in fig.select_traces(col=col + 1):
+                assert days_check[col] in trace.hovertemplate
+
+        for row in range(len(times_check)):
+            for trace in fig.select_traces(row=2 - row):
+                assert times_check[row] in trace.hovertemplate
+
+        for trace in fig.data:
+            for i, day in enumerate(days_check):
+                if day in trace.name:
+                    assert trace.marker.symbol == symbol_sequence[i]
+            for i, time in enumerate(times_check):
+                if time in trace.name:
+                    assert trace.marker.color == color_sequence[i]
+
+    assert_orderings(
+        ["x", "Sun", "Sat", "y", "Fri", "z"],  # add extra noise, missing Thur
+        ["Sun", "Sat", "Fri", "Thur"],  # Thur is at the back
+        ["a", "Lunch", "b"],  # add extra noise, missing Dinner
+        ["Lunch", "Dinner"],  # Dinner is at the back
+    )
+
     for days in permutations(df["day"].unique()):
         for times in permutations(df["time"].unique()):
-            fig = px.scatter(
-                df,
-                x="total_bill",
-                y="tip",
-                facet_row="time",
-                facet_col="day",
-                color="time",
-                symbol="day",
-                symbol_sequence=symbol_sequence,
-                color_discrete_sequence=color_sequence,
-                category_orders=dict(day=days, time=times),
-            )
-
-            for col in range(len(days)):
-                for trace in fig.select_traces(col=col + 1):
-                    assert days[col] in trace.hovertemplate
-
-            for row in range(len(times)):
-                for trace in fig.select_traces(row=2 - row):
-                    assert times[row] in trace.hovertemplate
-
-            for trace in fig.data:
-                for i, day in enumerate(days):
-                    if day in trace.name:
-                        assert trace.marker.symbol == symbol_sequence[i]
-                for i, time in enumerate(times):
-                    if time in trace.name:
-                        assert trace.marker.color == color_sequence[i]
+            assert_orderings(days, days, times, times)
+