add tests about last commit

Author: etpinard

plotly/tests/test_core/test_tools/test_get_subplots.py

@@ -8,10 +8,18 @@
 def test_non_integer_rows():
    fig = tls.get_subplots(rows=2.1)
 
+@raises(Exception)
+def test_less_than_zero_rows():
+   fig = tls.make_subplots(rows=-2)
+
 @raises(Exception)
 def test_non_integer_columns():
    fig = tls.get_subplots(columns=2/3)
 
+@raises(Exception)
+def test_less_than_zero_cols():
+   fig = tls.make_subplots(columns=-10)
+
 @raises(Exception)
 def test_wrong_kwarg():
    fig = tls.get_subplots(stuff='no gonna work')

plotly/tests/test_core/test_tools/test_make_subplots.py

@@ -9,8 +9,16 @@ def test_non_integer_rows():
    fig = tls.make_subplots(rows=2.1)
 
 @raises(Exception)
-def test_non_integer_columns():
-   fig = tls.make_subplots(columns=2/3)
+def test_less_than_zero_rows():
+   fig = tls.make_subplots(rows=-2)
+
+@raises(Exception)
+def test_non_integer_cols():
+   fig = tls.make_subplots(cols=2/3)
+
+@raises(Exception)
+def test_less_than_zero_cols():
+   fig = tls.make_subplots(cols=-10)
 
 @raises(Exception)
 def test_wrong_kwarg():
@@ -21,16 +29,16 @@ def test_non_integer_rows():
    fig = tls.make_subplots(rows=2.1)
 
 @raises(Exception)
-def test_non_integer_columns():
-   fig = tls.make_subplots(columns=2/3)
+def test_non_integer_cols():
+   fig = tls.make_subplots(cols=2/3)
 
 @raises(Exception)
 def test_wrong_kwarg():
    fig = tls.make_subplots(stuff='no gonna work')
 
 @raises(Exception)
 def test_start_cell_wrong_values():
-    fig = tls.make_subplots(rows=2, columns=2, start_cell='not gonna work')
+    fig = tls.make_subplots(rows=2, cols=2, start_cell='not gonna work')
 
 @raises(Exception)
 def test_specs_wrong_type():
@@ -51,12 +59,12 @@ def test_specs_wrong_item_key():
 @raises(Exception)
 def test_specs_underspecified():
     fig = tls.make_subplots(rows=2, specs=[{}])
-    fig = tls.make_subplots(rows=2, columns=2, specs=[[{}, {}], [{}]])
+    fig = tls.make_subplots(rows=2, cols=2, specs=[[{}, {}], [{}]])
 
 @raises(Exception)
 def test_specs_overspecified():
     fig = tls.make_subplots(rows=2, specs=[[{}], [{}], [{}]])
-    fig = tls.make_subplots(columns=2, specs=[{}, {}, {}])
+    fig = tls.make_subplots(cols=2, specs=[{}, {}, {}])
 
 @raises(Exception)
 def test_specs_colspan_too_big():