Merge branch 'master' into np2

Author: archmoj

.circleci/config.yml

@@ -234,6 +234,21 @@ jobs:
       - test_optional:
           py: "39_pandas_2"
 
+  # No numpy
+  python_312_no_numpy:
+    docker:
+      - image: cimg/python:3.12-browsers
+    steps:
+      - run:
+          name: Check that numpy is not installed
+          command: |
+            if pip list | grep numpy > /dev/null 2>&1
+            then exit 1
+            else exit 0
+            fi
+      - test_optional:
+          py: "312_no_numpy"
+
   # Orca
   python_38_orca:
     docker:
@@ -598,5 +613,6 @@ workflows:
       - python_39_pandas_2_optional
       - python_38_orca
       - python_39_percy
+      - python_312_no_numpy
       - build-doc
 

CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## UNRELEASED
+
+### Updated
+- Fixed a bug in integer validation of arrays that threw an error when an array contained a mix of strings and integers.
+
 ## [5.23.0] - 2024-07-23
 
 ### Updated

packages/python/plotly/_plotly_utils/basevalidators.py

@@ -950,7 +950,8 @@ def validate_coerce(self, v):
                 invalid_els = [
                     e
                     for e in v
-                    if not (self.min_val <= e <= self.max_val) and e not in self.extras
+                    if not (isinstance(e, int) and self.min_val <= e <= self.max_val)
+                    and e not in self.extras
                 ]
 
                 if invalid_els:

packages/python/plotly/_plotly_utils/tests/validators/test_integer_validator.py

@@ -33,6 +33,18 @@ def validator_aok(request):
     return IntegerValidator("prop", "parent", min=-2, max=10, array_ok=True)
 
 
+@pytest.fixture
+def validator_extras():
+    return IntegerValidator("prop", "parent", min=-2, max=10, extras=["normal", "bold"])
+
+
+@pytest.fixture
+def validator_extras_aok():
+    return IntegerValidator(
+        "prop", "parent", min=-2, max=10, array_ok=True, extras=["normal", "bold"]
+    )
+
+
 # ### Acceptance ###
 @pytest.mark.parametrize("val", [1, -19, 0, -1234])
 def test_acceptance(val, validator):
@@ -57,6 +69,27 @@ def test_acceptance_min_max(val, validator_min_max):
     assert validator_min_max.validate_coerce(val) == approx(val)
 
 
+# With extras
+@pytest.mark.parametrize("val", ["normal", "bold", 10, -2])
+def test_acceptance_extras(val, validator_extras):
+    assert validator_extras.validate_coerce(val) == val
+
+
+# Test extras for array_ok
+@pytest.mark.parametrize("val", [[10, "normal", "bold"], ["normal"], [10, -2], [5]])
+def test_acceptance_extras_array(val, validator_extras_aok):
+    assert validator_extras_aok.validate_coerce(val) == val
+
+
+# Test rejection by extras
+@pytest.mark.parametrize("val", ["invalid value", "different invalid value", -3, 11])
+def test_rejection_extras(val, validator_extras):
+    with pytest.raises(ValueError) as validation_failure:
+        validator_extras.validate_coerce(val)
+
+    assert "Invalid value" in str(validation_failure.value)
+
+
 @pytest.mark.parametrize(
     "val", [-1.01, -10, 2.1, 3, np.iinfo(int).max, np.iinfo(int).min]
 )

packages/python/plotly/test_requirements/requirements_312_no_numpy_optional.txt

@@ -0,0 +1,21 @@
+requests==2.31.0
+tenacity==8.2.3
+pandas
+xarray==2023.12.0
+statsmodels
+Pillow==10.2.0
+pytest==7.4.4
+pytz==2023.3.post1
+ipython[all]==7.22.0
+ipywidgets<8
+ipykernel==5.5.3
+jupyter==1.0.0
+scipy==1.11.4
+Shapely==2.0.2
+geopandas==0.14.2
+pyshp==2.3.1
+matplotlib==3.8.2
+scikit-image==0.22.0
+psutil==5.9.7
+kaleido
+orjson==3.9.10