implement connectGaps false

Author: mikolalysenko

devtools/test_dashboard/test_gl3d.js

@@ -36,5 +36,6 @@ plots['scatter3d-colorscale'] = require('@mocks/gl3d_scatter3d-colorscale.json')
 plots['autocolorscale'] = require('@mocks/gl3d_autocolorscale.json');
 plots['nan-holes'] = require('@mocks/gl3d_nan-holes.json');
 plots['tetrahedra'] = require('@mocks/gl3d_tet.json');
+plots['connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json');
 
 plotButtons(plots, figDir);

package.json

@@ -54,7 +54,7 @@
     "gl-error2d": "^1.0.0",
     "gl-error3d": "^1.0.0",
     "gl-line2d": "^1.2.1",
-    "gl-line3d": "^1.0.1",
+    "gl-line3d": "^1.1.0",
     "gl-mat4": "^1.1.2",
     "gl-mesh3d": "^1.0.7",
     "gl-plot2d": "^1.1.6",

src/traces/scatter3d/attributes.js

@@ -95,6 +95,12 @@ module.exports = {
         y: makeProjectionAttr('y'),
         z: makeProjectionAttr('z')
     },
+    connectgaps: {
+        valType: 'boolean',
+        role: 'style',
+        dfl: false,
+        description: 'Connects gaps in data'
+    },
     line: {
         color: scatterLineAttrs.color,
         width: scatterLineAttrs.width,

src/traces/scatter3d/convert.js

@@ -303,7 +303,8 @@ proto.update = function(data) {
         lineWidth: options.lineWidth || 1,
         dashes: dashPattern[0],
         dashScale: dashPattern[1],
-        opacity: data.opacity
+        opacity: data.opacity,
+        connectGaps: data.connectgaps
     };
 
     if(this.mode.indexOf('lines') !== -1) {

src/traces/scatter3d/defaults.js

@@ -34,6 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     coerce('text');
     coerce('mode');
+    coerce('connectgaps');
 
     if(subTypes.hasLines(traceOut)) {
         handleLineDefaults(traceIn, traceOut, defaultColor, coerce);

test/image/mocks/gl3d_scatter3d-connectgaps.json

@@ -0,0 +1,13 @@
+{
+  "data": [{
+    "type": "scatter3d",
+    "mode": "lines",
+    "x": [0, 1, 2, 3, 4, 5],
+    "y": [0, 1, 2, 3, 4, 5],
+    "z": [2, 1, null, null, 0, 3],
+    "connectgaps": false
+  }],
+  "layout": {
+    "title": "connect gaps test",
+  }
+}