fix smith chart react

Author: archmoj

src/plots/smith/layout_attributes.js

@@ -73,12 +73,10 @@ var imaginaryAxisAttrs = extendFlat({
     visible: extendFlat({}, axesAttrs.visible, {dflt: true}),
 
     tickvals: {
+        dflt: [-5, -2, -1, -0.5, -0.2, 0, 0.2, 0.5, 1, 2, 5],
         valType: 'data_array',
         editType: 'plot',
-        description: [
-            'Sets the values at which ticks on this axis appear.',
-            'Defaults to `realaxis.tickvals` plus the same as negatives and zero.'
-        ].join(' ')
+        description: 'Sets the values at which ticks on this axis appear.'
     },
 
     ticks: axesAttrs.ticks,

src/plots/smith/layout_defaults.js

@@ -52,17 +52,7 @@ function handleDefaults(contIn, contOut, coerce, opts) {
             var isRealAxis = axName === 'realaxis';
             if(isRealAxis) coerceAxis('side');
 
-            if(isRealAxis) {
-                coerceAxis('tickvals');
-            } else {
-                var realTickvals = contOut.realaxis.tickvals || layoutAttributes.realaxis.tickvals.dflt;
-                var imagTickvalsDflt =
-                    realTickvals.slice().reverse().map(function(x) { return -x; })
-                    .concat([0])
-                    .concat(realTickvals);
-
-                coerceAxis('tickvals', imagTickvalsDflt);
-            }
+            coerceAxis('tickvals');
 
             var dfltColor;
             var dfltFontColor;

test/image/mocks/smith_basic.json

@@ -25,6 +25,9 @@
     "smith": {
       "realaxis": {
         "tickvals": [0.2, 0.4, 0.6, 0.8, 1, 1.5, 2, 3, 4, 5, 10, 20]
+      },
+      "imaginaryaxis": {
+        "tickvals": [-20, -10, -5, -4, -3, -2, -1.5, -1, -0.8, -0.6, -0.4, -0.2, 0, 0.2, 0.4, 0.6, 0.8, 1, 1.5, 2, 3, 4, 5, 10, 20]
       }
     }
   }

test/jasmine/tests/smith_test.js

@@ -106,19 +106,19 @@ describe('Test relayout on smith subplots:', function() {
             return Plotly.relayout(gd, 'smith.imaginaryaxis', {ticks: 'inside'});
         })
         .then(function() {
-            check(26, 'M-0.5,0h-5');
+            check(12, 'M-0.5,0h-5');
             return Plotly.relayout(gd, 'smith.imaginaryaxis', {ticks: 'outside'});
         })
         .then(function() {
-            check(26, 'M0.5,0h5');
+            check(12, 'M0.5,0h5');
             return Plotly.relayout(gd, 'smith.imaginaryaxis', {ticks: ''});
         })
         .then(function() {
             check(0);
             return Plotly.relayout(gd, 'smith.imaginaryaxis', {ticks: 'inside'});
         })
         .then(function() {
-            check(26, 'M-0.5,0h-5');
+            check(12, 'M-0.5,0h-5');
         })
         .then(done, done.fail);
     });

test/plot-schema.json

@@ -7510,7 +7510,20 @@
       "valType": "string"
      },
      "tickvals": {
-      "description": "Sets the values at which ticks on this axis appear. Defaults to `realaxis.tickvals` plus the same as negatives and zero.",
+      "description": "Sets the values at which ticks on this axis appear.",
+      "dflt": [
+       -5,
+       -2,
+       -1,
+       -0.5,
+       -0.2,
+       0,
+       0.2,
+       0.5,
+       1,
+       2,
+       5
+      ],
       "editType": "plot",
       "valType": "data_array"
      },