clear selectio polygon cache on scroll

Author: etpinard

src/plots/cartesian/dragbox.js

@@ -178,11 +178,9 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             prepSelect(e, startX, startY, dragOptions, dragModeNow);
         } else {
             dragOptions.clickFn = clickFn;
-            // clear selection polygon cache (if any)
-            plotinfo.selection = false;
 
             if(allFixedRanges) {
-                clearSelect(zoomlayer);
+                clearAndResetSelect();
             } else if(dragModeNow === 'zoom') {
                 dragOptions.moveFn = zoomMove;
                 dragOptions.doneFn = zoomDone;
@@ -196,11 +194,18 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             } else if(dragModeNow === 'pan') {
                 dragOptions.moveFn = plotDrag;
                 dragOptions.doneFn = dragTail;
-                clearSelect(zoomlayer);
+                clearAndResetSelect();
             }
         }
     };
 
+    function clearAndResetSelect() {
+        // clear selection polygon cache (if any)
+        dragOptions.plotinfo.selection = false;
+        // clear selection outlines
+        clearSelect(zoomlayer);
+    }
+
     function clickFn(numClicks, evt) {
         removeZoombox(gd);
 
@@ -281,7 +286,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
 
         corners = makeCorners(zoomlayer, xs, ys);
 
-        clearSelect(zoomlayer);
+        clearAndResetSelect();
     }
 
     function zoomMove(dx0, dy0) {
@@ -393,7 +398,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             return;
         }
 
-        clearSelect(zoomlayer);
+        clearAndResetSelect();
 
         // If a transition is in progress, then disable any behavior:
         if(gd._transitioningWithDuration) {

test/jasmine/tests/select_test.js

@@ -745,6 +745,7 @@ describe('@flaky Test select box and lasso in general:', function() {
         fig.layout.width = 500;
         fig.layout.height = 500;
         fig.layout.dragmode = 'select';
+        fig.config = {scrollZoom: true};
 
         // d attr to array of segment [x,y]
         function outline2coords(outline) {
@@ -856,6 +857,16 @@ describe('@flaky Test select box and lasso in general:', function() {
                 ]
             });
         })
+        .then(function() {
+            mouseEvent('mousemove', 200, 200);
+            mouseEvent('scroll', 200, 200, {deltaX: 0, deltaY: -20});
+        })
+        .then(_drag(path1, {shiftKey: true}))
+        .then(function() {
+            _assert('shift select path1 after scroll', {
+                outline: [[150, 150], [150, 170], [170, 170], [170, 150], [150, 150]]
+            });
+        })
         .catch(failTest)
         .then(done);
     });