plots: relink subplot before relink _ keys in fullLayout

- so that old axis scale fields (e.g _length, _m, ...) in fullLayout
  don't get relinked in subplot objects, leading to incorrect
  relayout / resize.

Author: etpinard

src/plots/plots.js

@@ -402,6 +402,9 @@ plots.supplyDefaults = function(gd) {
     // clean subplots and other artifacts from previous plot calls
     plots.cleanPlot(newFullData, newFullLayout, oldFullData, oldFullLayout);
 
+    // relink / initialize subplot axis objects
+    plots.linkSubplots(newFullData, newFullLayout, oldFullData, oldFullLayout);
+
     // relink functions and _ attributes to promote consistency between plots
     relinkPrivateKeys(newFullLayout, oldFullLayout);
 
@@ -416,9 +419,6 @@ plots.supplyDefaults = function(gd) {
         ax.setScale();
     }
 
-    // relink / initialize subplot axis objects
-    plots.linkSubplots(newFullData, newFullLayout, oldFullData, oldFullLayout);
-
     // update object references in calcdata
     if((gd.calcdata || []).length === newFullData.length) {
         for(i = 0; i < newFullData.length; i++) {

test/jasmine/tests/plots_test.js

@@ -248,7 +248,7 @@ describe('Test Plots', function() {
     describe('Plots.resize', function() {
         var gd;
 
-        beforeEach(function(done) {
+        beforeAll(function(done) {
             gd = createGraphDiv();
 
             Plotly.plot(gd, [{ x: [1, 2, 3], y: [2, 3, 4] }], {})
@@ -287,6 +287,17 @@ describe('Test Plots', function() {
                 expect(svgHeight).toBe(400);
             }
         });
+
+        it('should update the axis scales', function() {
+            var fullLayout = gd._fullLayout,
+                plotinfo = fullLayout._plots.xy;
+
+            expect(fullLayout.xaxis._length).toEqual(240);
+            expect(fullLayout.yaxis._length).toEqual(220);
+
+            expect(plotinfo.xaxis._length).toEqual(240);
+            expect(plotinfo.yaxis._length).toEqual(220);
+        });
     });
 
     describe('Plots.purge', function() {