Skip to content

Commit f3a071e

Browse files
committed
waterfall marker description - set default to between mode - added spanning to few mocks - updated baselines
1 parent 4eb5daf commit f3a071e

14 files changed

+15
-11
lines changed

src/traces/waterfall/attributes.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,24 +12,24 @@ var barAttrs = require('../bar/attributes');
1212
var lineAttrs = require('../scatter/attributes').line;
1313
var extendFlat = require('../../lib/extend').extendFlat;
1414

15-
function directionAttrs() {
15+
function directionAttrs(dirTxt) {
1616
return {
1717
marker: {
1818
color: extendFlat({}, barAttrs.marker.color, {
1919
arrayOk: false,
2020
editType: 'style',
21-
description: ''
21+
description: 'Sets the marker color of all ' + dirTxt + ' values.'
2222
}),
2323
line: {
2424
color: extendFlat({}, barAttrs.marker.line.color, {
2525
arrayOk: false,
2626
editType: 'style',
27-
description: ''
27+
description: 'Sets the line color of all ' + dirTxt + ' values.'
2828
}),
2929
width: extendFlat({}, barAttrs.marker.line.width, {
3030
arrayOk: false,
3131
editType: 'style',
32-
description: ''
32+
description: 'Sets the line width of all ' + dirTxt + ' values.'
3333
}),
3434
editType: 'style',
3535
},
@@ -88,9 +88,9 @@ module.exports = {
8888
offset: barAttrs.offset,
8989
width: barAttrs.width,
9090

91-
increasing: directionAttrs(),
92-
decreasing: directionAttrs(),
93-
totals: directionAttrs(),
91+
increasing: directionAttrs('increasing'),
92+
decreasing: directionAttrs('decreasing'),
93+
totals: directionAttrs('intermediate sums and total'),
9494

9595
connector: {
9696
line: {
@@ -102,7 +102,7 @@ module.exports = {
102102
mode: {
103103
valType: 'enumerated',
104104
values: ['spanning', 'between'],
105-
dflt: 'spanning',
105+
dflt: 'between',
106106
role: 'info',
107107
editType: 'plot',
108108
description: [
311 Bytes
Loading
527 Bytes
Loading
81 Bytes
Loading
28 Bytes
Loading
-38 Bytes
Loading
45 Bytes
Loading
30 Bytes
Loading
27 Bytes
Loading

test/image/mocks/waterfall_and_bar.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
null
9797
],
9898
"connector": {
99+
"mode": "spanning",
99100
"line": {
100101
"width": 2,
101102
"color": "rgb(0, 0, 0)",

0 commit comments

Comments
 (0)