parcoords - bug fix undefined ranges and ticks

Author: archmoj

src/traces/parcoords/defaults.js

@@ -55,6 +55,19 @@ function dimensionDefaults(dimensionIn, dimensionOut, parentOut, opts) {
         coerce('ticktext');
         coerce('tickformat');
         var range = coerce('range');
+        if(!range) {
+            var max = -Infinity;
+            var min = Infinity;
+            for(var i = 0; i < values.length; i++) {
+                var v = values[i];
+                if(isFinite(v)) {
+                    if(max < v) max = v;
+                    if(min > v) min = v;
+                }
+            }
+
+            range = [min, max];
+        }
 
         dimensionOut._ax = {
             _id: 'y',

src/traces/parcoords/parcoords.js

@@ -206,7 +206,7 @@ function viewModel(state, callbacks, model) {
     var unitPad = c.verticalPadding / height;
     var _unitToPaddedPx = unitToPaddedPx(height, c.verticalPadding);
 
-    var viewModel = {
+    var vm = {
         key: model.key,
         xScale: xScale,
         model: model,
@@ -215,7 +215,7 @@ function viewModel(state, callbacks, model) {
 
     var uniqueKeys = {};
 
-    viewModel.dimensions = dimensions.filter(helpers.isVisible).map(function(dimension, i) {
+    vm.dimensions = dimensions.filter(helpers.isVisible).map(function(dimension, i) {
         var domainToPaddedUnit = domainToPaddedUnitScale(dimension, unitPad);
         var foundKey = uniqueKeys[dimension.label];
         uniqueKeys[dimension.label] = (foundKey || 0) + 1;
@@ -229,7 +229,7 @@ function viewModel(state, callbacks, model) {
             specifiedConstraint.map(function(d) { return d.map(domainToPaddedUnit); }) :
             [[-Infinity, Infinity]];
         var brushMove = function() {
-            var p = viewModel;
+            var p = vm;
             p.focusLayer && p.focusLayer.render(p.panels, true);
             var filtersActive = someFiltersActive(p);
             if(!state.contextShown() && filtersActive) {
@@ -299,7 +299,7 @@ function viewModel(state, callbacks, model) {
             unitToPaddedPx: _unitToPaddedPx,
             domainScale: domainScale(height, c.verticalPadding, dimension, tickvals, ticktext),
             ordinalScale: ordinalScale(dimension),
-            parent: viewModel,
+            parent: vm,
             model: model,
             brush: brush.makeBrush(
                 state,
@@ -310,9 +310,8 @@ function viewModel(state, callbacks, model) {
                 },
                 brushMove,
                 function(f) {
-                    var p = viewModel;
-                    p.focusLayer.render(p.panels, true);
-                    p.pickLayer && p.pickLayer.render(p.panels, true);
+                    vm.focusLayer.render(vm.panels, true);
+                    vm.pickLayer && vm.pickLayer.render(vm.panels, true);
                     state.linePickActive(true);
                     if(callbacks && callbacks.filterChanged) {
                         var invScale = domainToPaddedUnit.invert;
@@ -321,14 +320,14 @@ function viewModel(state, callbacks, model) {
                         var newRanges = f.map(function(r) {
                             return r.map(invScale).sort(Lib.sorterAsc);
                         }).sort(function(a, b) { return a[0] - b[0]; });
-                        callbacks.filterChanged(p.key, dimension._index, newRanges);
+                        callbacks.filterChanged(vm.key, dimension._index, newRanges);
                     }
                 }
             )
         };
     });
 
-    return viewModel;
+    return vm;
 }
 
 function styleExtentTexts(selection) {
@@ -386,8 +385,7 @@ function calcAllTicks(cd) {
                 var dim = dimensions[k]._ax;
 
                 if(dim) {
-                    if(!dim.range) dim.range = [0, 1];
-                    if(!dim.dtick) dim.dtick = 0.1;
+                    if(!dim.dtick) dim.dtick = 0.01 * Math.abs(dim.range[1] - dim.range[0]);
                     dim.tickformat = dimensions[k].tickformat;
 
                     Axes.calcTicks(dim);
@@ -399,27 +397,28 @@ function calcAllTicks(cd) {
     }
 }
 
-module.exports = function parcoords(gd, cdModule, layout, callbacks) {
-    var state = parcoordsInteractionState();
+function linearFormat(dim, v) {
+    return Axes.tickText(dim._ax, v, false).text;
+}
 
-    var fullLayout = gd._fullLayout;
-    var svg = fullLayout._toppaper;
-    var glContainer = fullLayout._glcontainer;
+function extremeText(d, isTop) {
+    if(d.ordinal) return '';
+    var domain = d.domainScale.domain();
+    var v = (domain[isTop ? domain.length - 1 : 0]);
 
-    function linearFormat(dim, v) {
-        return Axes.tickText(dim._ax, v, false).text;
-    }
+    return linearFormat(d.model.dimensions[d.visibleIndex], v);
+}
 
-    function extremeText(d, isTop) {
-        if(d.ordinal) return '';
-        var domain = d.domainScale.domain();
-        var v = (domain[isTop ? domain.length - 1 : 0]);
 
-        return linearFormat(d.model.dimensions[d.visibleIndex], v);
-    }
+module.exports = function parcoords(gd, cdModule, layout, callbacks) {
+    var fullLayout = gd._fullLayout;
+    var svg = fullLayout._toppaper;
+    var glContainer = fullLayout._glcontainer;
 
     calcAllTicks(cdModule);
 
+    var state = parcoordsInteractionState();
+
     var vm = cdModule
         .filter(function(d) { return unwrap(d).trace.visible; })
         .map(model.bind(0, layout))
@@ -509,14 +508,14 @@ module.exports = function parcoords(gd, cdModule, layout, callbacks) {
     });
 
     var yAxis = parcoordsControlView.selectAll('.' + c.cn.yAxis)
-        .data(function(vm) { return vm.dimensions; }, keyFun);
+        .data(function(p) { return p.dimensions; }, keyFun);
 
     yAxis.enter()
         .append('g')
         .classed(c.cn.yAxis, true);
 
-    parcoordsControlView.each(function(vm) {
-        updatePanelLayout(yAxis, vm);
+    parcoordsControlView.each(function(p) {
+        updatePanelLayout(yAxis, p);
     });
 
     glLayers