Merge pull request #3191 from plotly/parcats_dark

Use paper_bgcolor for parcats text-shadow instead of hardcoding to white

Author: etpinard

src/traces/parcats/parcats.js

@@ -230,6 +230,8 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
         .attr('class', 'catlabel')
         .attr('pointer-events', 'none');
 
+    var paperColor = graphDiv._fullLayout.paper_bgcolor;
+
     // Update category label
     categorySelection.select('text.catlabel')
         .attr('text-anchor',
@@ -245,10 +247,10 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
         .attr('alignment-baseline', 'middle')
 
         .style('text-shadow',
-            'rgb(255, 255, 255) -1px  1px 2px, ' +
-            'rgb(255, 255, 255)  1px  1px 2px, ' +
-            'rgb(255, 255, 255)  1px -1px 2px, ' +
-            'rgb(255, 255, 255) -1px -1px 2px')
+            paperColor + ' -1px  1px 2px, ' +
+            paperColor + ' 1px  1px 2px, ' +
+            paperColor + '  1px -1px 2px, ' +
+            paperColor + ' -1px -1px 2px')
         .style('fill', 'rgb(0, 0, 0)')
         .attr('x',
             function(d) {

test/image/baselines/parcats_dark.png

@@ -0,0 +1,18 @@
+{
+  "data": [
+    {"type": "parcats",
+      "domain": {"x": [0.125, 0.625],"y": [0.25, 0.75]},
+      "dimensions":[
+        {"label": "One", "values": [1, 1, 2, 1, 2, 1, 1, 2, 1]},
+        {"label": "Two", "values": ["A", "B", "A", "B", "C", "C", "A", "B", "C"]},
+        {"label": "Three", "values": [11, 11, 11, 11, 11, 11, 11, 11, 11]}]}
+  ],
+  "layout": {
+    "paper_bgcolor": "black",
+    "font": {"color": "white"},
+    "height": 602,
+    "width": 592,
+    "margin": {
+      "l": 40, "r": 40, "t": 50, "b": 40
+    }}
+}