call PlotSchema.findArrayAttributes in doCalcdata

- no need to call on every update,
  when data array change is sufficient.
- note that the groupby transform still need to
  call Plots.findArrayAttributes on its own as its transform method
  is called during the defaults.

Author: etpinard

src/plots/plots.js

@@ -521,7 +521,7 @@ plots.supplyDefaults = function(gd) {
 
 function remapTransformedArrays(cd0, newTrace) {
     var oldTrace = cd0.trace;
-    var arrayAttrs = PlotSchema.findArrayAttributes(oldTrace);
+    var arrayAttrs = oldTrace._arrayAttrs;
     var transformedArrayHash = {};
     var i, astr;
 
@@ -676,9 +676,6 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
         Lib.pushUnique(modules, _module);
         Lib.pushUnique(basePlotModules, fullTrace._module.basePlotModule);
 
-        // TODO remove findArrayAttributes calls downstream
-        fullTrace._arrayAttrs = PlotSchema.findArrayAttributes(fullTrace);
-
         cnt++;
     }
 
@@ -2038,6 +2035,12 @@ plots.doCalcdata = function(gd, traces) {
         }
     }
 
+    // find array attributes in trace
+    for(i = 0; i < fullData.length; i++) {
+        trace = fullData[i];
+        trace._arrayAttrs = PlotSchema.findArrayAttributes(trace);
+    }
+
     initCategories(axList);
 
     var hasCalcTransform = false;

src/transforms/filter.js

@@ -10,7 +10,6 @@
 
 var Lib = require('../lib');
 var Registry = require('../registry');
-var PlotSchema = require('../plot_api/plot_schema');
 var Axes = require('../plots/cartesian/axes');
 
 var COMPARISON_OPS = ['=', '!=', '<', '>=', '>', '<='];
@@ -148,6 +147,7 @@ exports.calcTransform = function(gd, trace, opts) {
     var target = opts.target;
     var len = targetArray.length;
     var targetCalendar = opts.targetcalendar;
+    var arrayAttrs = trace._arrayAttrs;
 
     // even if you provide targetcalendar, if target is a string and there
     // is a calendar attribute matching target it will get used instead.
@@ -158,7 +158,6 @@ exports.calcTransform = function(gd, trace, opts) {
 
     var d2c = Axes.getDataToCoordFunc(gd, trace, target, targetArray);
     var filterFunc = getFilterFunc(opts, d2c, targetCalendar);
-    var arrayAttrs = PlotSchema.findArrayAttributes(trace);
     var originalArrays = {};
 
     function forAllAttrs(fn, index) {

src/transforms/sort.js

@@ -9,7 +9,6 @@
 'use strict';
 
 var Lib = require('../lib');
-var PlotSchema = require('../plot_api/plot_schema');
 var Axes = require('../plots/cartesian/axes');
 
 exports.moduleType = 'transform';
@@ -78,7 +77,7 @@ exports.calcTransform = function(gd, trace, opts) {
 
     var target = opts.target;
     var len = targetArray.length;
-    var arrayAttrs = PlotSchema.findArrayAttributes(trace);
+    var arrayAttrs = trace._arrayAttrs;
     var d2c = Axes.getDataToCoordFunc(gd, trace, target, targetArray);
     var indices = getIndices(opts, targetArray, d2c);