Reduce test delays and fix uncovered bug

Fixup double_click asset
Cleanup legend item selection code in editable mode

Author: rpaskowitz

src/components/legend/draw.js

@@ -334,15 +334,13 @@ module.exports = function draw(gd) {
                 if(dragged && xf !== undefined && yf !== undefined) {
                     Plotly.relayout(gd, {'legend.x': xf, 'legend.y': yf});
                 } else {
-                    var traces = [],
-                        clickedTrace;
-                    traces = fullLayout._infolayer.selectAll('g.traces').filter(function() {
-                        var bbox = this.getBoundingClientRect();
-                        return (e.clientX >= bbox.left && e.clientX <= bbox.right &&
-                            e.clientY >= bbox.top && e.clientY <= bbox.bottom);
-                    })[0];
-                    if(traces.length > 0) {
-                        clickedTrace = d3.select(traces[0]);
+                    var clickedTrace =
+                        fullLayout._infolayer.selectAll('g.traces').filter(function() {
+                            var bbox = this.getBoundingClientRect();
+                            return (e.clientX >= bbox.left && e.clientX <= bbox.right &&
+                                e.clientY >= bbox.top && e.clientY <= bbox.bottom);
+                        });
+                    if(clickedTrace.size() > 0) {
                         if(numClicks === 1) {
                             legend._clickTimeout = setTimeout(function() { handleClick(clickedTrace, gd, numClicks); }, DBLCLICKDELAY);
                         } else if(numClicks === 2) {
@@ -458,6 +456,7 @@ function setupTraceToggle(g, gd) {
             if(legend._clickTimeout) {
                 clearTimeout(legend._clickTimeout);
             }
+            gd._legendMouseDownTime = 0;
             handleClick(g, gd, numClicks);
         }
     });

test/jasmine/assets/double_click.js

@@ -1,5 +1,5 @@
 var click = require('./click');
-var DBLCLICKDELAY = require('@src/plots/cartesian/constants').DBLCLICKDELAY;
+var DBLCLICKDELAY = require('@src/constants/interactions').DBLCLICKDELAY;
 
 module.exports = function doubleClick(x, y) {
     return new Promise(function(resolve) {

test/jasmine/tests/legend_test.js

@@ -661,7 +661,7 @@ describe('legend interaction', function() {
                     expect(gd._fullLayout.hiddenlabels.length).toBe(1);
                     expect(gd._fullLayout.hiddenlabels[0]).toBe(legendLabel);
                     done();
-                }, DBLCLICKDELAY * 2);
+                }, DBLCLICKDELAY + 20);
             });
             it('should fade legend item', function() {
                 expect(+legendItem.parentNode.style.opacity).toBeLessThan(1);
@@ -672,7 +672,7 @@ describe('legend interaction', function() {
                 setTimeout(function() {
                     expect(gd._fullLayout.hiddenlabels.length).toBe(0);
                     done();
-                }, DBLCLICKDELAY * 2);
+                }, DBLCLICKDELAY + 20);
             });
             it('should unfade legend item', function() {
                 expect(+legendItem.parentNode.style.opacity).toBe(1);
@@ -689,7 +689,7 @@ describe('legend interaction', function() {
                     expect(gd._fullLayout.hiddenlabels.length).toBe((legendItems.length - 1));
                     expect(gd._fullLayout.hiddenlabels.indexOf(legendLabel)).toBe(-1);
                     done();
-                }, DBLCLICKDELAY);
+                }, 20);
             });
             it('should fade other legend items', function() {
                 var legendItemi;
@@ -710,7 +710,7 @@ describe('legend interaction', function() {
                 setTimeout(function() {
                     expect(gd._fullLayout.hiddenlabels.length).toBe(0);
                     done();
-                }, DBLCLICKDELAY);
+                }, 20);
             });
             it('should unfade legend items', function() {
                 var legendItemi;
@@ -747,7 +747,7 @@ describe('legend interaction', function() {
                 setTimeout(function() {
                     expect(gd.data[2].visible).toBe('legendonly');
                     done();
-                }, DBLCLICKDELAY * 2);
+                }, DBLCLICKDELAY + 20);
             });
             it('should fade legend item', function() {
                 expect(+legendItem.parentNode.style.opacity).toBeLessThan(1);
@@ -758,7 +758,7 @@ describe('legend interaction', function() {
                 setTimeout(function() {
                     expect(gd.data[2].visible).toBe(true);
                     done();
-                }, DBLCLICKDELAY * 2);
+                }, DBLCLICKDELAY + 20);
             });
             it('should unfade legend item', function() {
                 expect(+legendItem.parentNode.style.opacity).toBe(1);
@@ -779,7 +779,7 @@ describe('legend interaction', function() {
                         }
                     }
                     done();
-                }, DBLCLICKDELAY);
+                }, 20);
             });
             it('should fade legend item', function() {
                 var legendItemi;
@@ -802,7 +802,7 @@ describe('legend interaction', function() {
                         expect(gd.data[i].visible).toBe(true);
                     }
                     done();
-                }, DBLCLICKDELAY);
+                }, 20);
             });
             it('should unfade legend items', function() {
                 var legendItemi;