similar fix for parcoords.dimensions.values typedArray case

Author: archmoj

src/traces/parcoords/defaults.js

@@ -20,8 +20,8 @@ var maxDimensionCount = require('./constants').maxDimensionCount;
 var mergeLength = require('./merge_length');
 
 function handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
-    var lineColor = coerce('line.color', defaultColor);
 
+    var lineColor = coerce('line.color', defaultColor);
     if(!Array.isArray(lineColor) && Lib.isArrayOrTypedArray(lineColor)) {
         // should convert typed arrays e.g. integers to real numbers
         lineColor = traceOut.line.color = Array.prototype.slice.call(lineColor);
@@ -49,6 +49,11 @@ function dimensionDefaults(dimensionIn, dimensionOut) {
     }
 
     var values = coerce('values');
+    if(!Array.isArray(values) && Lib.isArrayOrTypedArray(values)) {
+        // should convert typed arrays e.g. integers to real numbers
+        values = dimensionOut.values = Array.prototype.slice.call(values);
+    }
+
     var visible = coerce('visible');
     if(!(values && values.length)) {
         visible = dimensionOut.visible = false;

test/jasmine/tests/parcoords_test.js

@@ -145,7 +145,7 @@ describe('parcoords initialization tests', function() {
             });
         });
 
-        it('\'line.color\' should convert typed arrays to normal arrays', function() {
+        it('\'dimensions.values\' and \'line.color\' should convert typed arrays to normal arrays', function() {
             var fullTrace = _supply({
                 dimensions: [{
                     range: [1, 5],
@@ -154,17 +154,19 @@ describe('parcoords initialization tests', function() {
                 }, {
                     range: [1, 5],
                     label: 'B',
-                    values: [3, 1.5, 2],
+                    values: new Float64Array([3, 1.5, 2]),
                 }, {
                     range: [1, 5],
                     label: 'C',
-                    values: [2, 4, 1],
+                    values: new Int32Array([2, 4, 1]),
                 }],
                 line: {
                     color: new Int32Array([0, 1, 2])
                 }
             });
             expect(Array.isArray(fullTrace.line.color) === true).toEqual(true);
+            expect(Array.isArray(fullTrace.dimensions[1].values) === true).toEqual(true);
+            expect(Array.isArray(fullTrace.dimensions[2].values) === true).toEqual(true);
         });
 
         it('\'domain\' specification should have a default', function() {