PR feedback

Author: nicolaskruchten

src/components/modebar/buttons.js

@@ -47,22 +47,28 @@ var modeBarButtons = module.exports = {};
 
 modeBarButtons.toImage = {
     name: 'toImage',
-    title: function(gd) { return _(gd, 'Download plot'); },
+    title: function(gd) {
+        var opts = gd._context.toImageButtonOptions || {};
+        var format = opts.format || 'png';
+        return format === 'png' ?
+            _(gd, 'Download plot as a png') : // legacy text
+            _(gd, 'Download plot'); // generic non-PNG text
+    },
     icon: Icons.camera,
     click: function(gd) {
-        var toImageButtonDefaults = gd._context.toImageButtonDefaults;
-        var opts = {format: toImageButtonDefaults.format || 'png'};
+        var toImageButtonOptions = gd._context.toImageButtonOptions;
+        var opts = {format: toImageButtonOptions.format || 'png'};
 
         Lib.notifier(_(gd, 'Taking snapshot - this may take a few seconds'), 'long');
 
-        if(Lib.isIE()) {
+        if(opts.format !== 'svg' && Lib.isIE()) {
             Lib.notifier(_(gd, 'IE only supports svg.  Changing format to svg.'), 'long');
             opts.format = 'svg';
         }
 
         ['filename', 'width', 'height', 'scale'].forEach(function(key) {
-            if(toImageButtonDefaults[key]) {
-                opts[key] = toImageButtonDefaults[key];
+            if(toImageButtonOptions[key]) {
+                opts[key] = toImageButtonOptions[key];
             }
         });
 

src/plot_api/plot_config.js

@@ -118,7 +118,7 @@ module.exports = {
     // statically override options for toImage modebar button
     // allowed keys are format, filename, width, height, scale
     // see ./components/modebar/buttons.js
-    toImageButtonDefaults: {},
+    toImageButtonOptions: {},
 
     // add the plotly logo on the end of the mode bar
     displaylogo: true,

test/jasmine/tests/modebar_test.js

@@ -788,7 +788,7 @@ describe('ModeBar', function() {
 
             it('should accept overriding defaults', function(done) {
                 Plotly.plot(gd, {data: [], layout: {}, config: {
-                    toImageButtonDefaults: {
+                    toImageButtonOptions: {
                         format: 'svg',
                         filename: 'x',
                         unsupported: 'should not pass'