missing aggregations array no longer throws - fix #2024

Author: bpostlethwaite

src/transforms/aggregate.js

@@ -155,31 +155,29 @@ exports.supplyDefaults = function(transformIn, traceOut) {
         arrayAttrs[groups] = 0;
     }
 
-    var aggregationsIn = transformIn.aggregations;
+    var aggregationsIn = transformIn.aggregations || [];
     var aggregationsOut = transformOut.aggregations = new Array(aggregationsIn.length);
     var aggregationOut;
 
     function coercei(attr, dflt) {
         return Lib.coerce(aggregationsIn[i], aggregationOut, aggAttrs, attr, dflt);
     }
 
-    if(aggregationsIn) {
-        for(i = 0; i < aggregationsIn.length; i++) {
-            aggregationOut = {};
-            var target = coercei('target');
-            var func = coercei('func');
-            var enabledi = coercei('enabled');
-
-            // add this aggregation to the output only if it's the first instance
-            // of a valid target attribute - or an unused target attribute with "count"
-            if(enabledi && target && (arrayAttrs[target] || (func === 'count' && arrayAttrs[target] === undefined))) {
-                if(func === 'stddev') coercei('funcmode');
-
-                arrayAttrs[target] = 0;
-                aggregationsOut[i] = aggregationOut;
-            }
-            else aggregationsOut[i] = {enabled: false};
+    for(i = 0; i < aggregationsIn.length; i++) {
+        aggregationOut = {};
+        var target = coercei('target');
+        var func = coercei('func');
+        var enabledi = coercei('enabled');
+
+        // add this aggregation to the output only if it's the first instance
+        // of a valid target attribute - or an unused target attribute with "count"
+        if(enabledi && target && (arrayAttrs[target] || (func === 'count' && arrayAttrs[target] === undefined))) {
+            if(func === 'stddev') coercei('funcmode');
+
+            arrayAttrs[target] = 0;
+            aggregationsOut[i] = aggregationOut;
         }
+        else aggregationsOut[i] = {enabled: false};
     }
 
     // any array attributes we haven't yet covered, fill them with the default aggregation

test/jasmine/tests/transform_aggregate_test.js

@@ -190,6 +190,26 @@ describe('aggregate', function() {
         expect(traceOut.marker.size).toEqual([10, 20]);
     });
 
+    // Regression test - throws before fix:
+    // https://github.com/plotly/plotly.js/issues/2024
+    it('can handle case where aggregation array is missing', function() {
+        Plotly.newPlot(gd, [{
+            x: [1, 2, 3, 4, 5],
+            y: [2, 4, 6, 8, 10],
+            marker: {size: [10, 10, 20, 20, 10]},
+            transforms: [{
+                type: 'aggregate',
+                groups: 'marker.size'
+            }]
+        }]);
+
+        var traceOut = gd._fullData[0];
+
+        expect(traceOut.x).toEqual([1, 3]);
+        expect(traceOut.y).toEqual([2, 6]);
+        expect(traceOut.marker.size).toEqual([10, 20]);
+    });
+
     it('handles median, mode, rms, & stddev for numeric data', function() {
         // again, nothing is going to barf with non-numeric data, but sometimes it
         // won't make much sense.