default *rotation* to 90 for clockwise *direction*

Author: etpinard

src/plots/polar/layout_attributes.js

@@ -200,7 +200,6 @@ var angularAxisAttrs = {
     direction: {
         valType: 'enumerated',
         values: ['counterclockwise', 'clockwise'],
-        // we could make the default 'clockwise' for category and date angular axes
         dflt: 'counterclockwise',
         role: 'info',
         editType: 'calc',
@@ -211,16 +210,15 @@ var angularAxisAttrs = {
 
     rotation: {
         valType: 'angle',
-        // we could maybe make `rotation: 90` by default for category and date angular axes
-        dflt: 0,
         editType: 'calc',
         role: 'info',
         description: [
             'Sets that start position (in degrees) of the angular axis',
-            'Note that by default, polar subplots are orientation such that the theta=0',
-            'corresponds to a line pointing right (like what mathematicians prefer).',
-            'For example to make the angular axis start from the North (like on a compass),',
-            'set `angularaxis.rotation` to *90*.'
+            'By default, polar subplots will `direction` set to *counterclockwise*',
+            'get a `rotation` of *0*',
+            'which corresponds to due East (like what mathematicians prefer).',
+            'In turn, polar with `direction` set to *clockwise* get a rotation of *90*',
+            'which corresponds to due North (like on a compass),'
         ].join(' ')
     },
 

src/plots/polar/layout_defaults.js

@@ -119,10 +119,8 @@ function handleDefaults(contIn, contOut, coerce, opts) {
                     coerceAxis('period');
                 }
 
-                // TODO maybe by default: non-linear axis
-                // should get direction: 'clockwise' + rotation: 90
-                coerceAxis('direction');
-                coerceAxis('rotation');
+                var direction = coerceAxis('direction');
+                coerceAxis('rotation', {counterclockwise: 0, clockwise: 90}[direction]);
 
                 setConvertAngular(axOut);
                 break;

test/image/baselines/polar_categories.png

@@ -48,6 +48,9 @@
       },
       "radialaxis": {
         "angle": 45
+      },
+      "angularaxis": {
+        "direction": "clockwise"
       }
     },
     "polar2": {

test/image/mocks/polar_categories.json

@@ -130,6 +130,24 @@ describe('Test polar plots defaults:', function() {
         expect(layoutOut.polar.radialaxis.linecolor).toBe('blue');
         expect(layoutOut.polar.radialaxis.gridcolor).toBe('rgb(153, 153, 255)', 'blend by 60% with bgcolor');
     });
+
+    it('should default *rotation* to 90 when clockwise *direction*', function() {
+        _supply({
+            polar: {}
+        });
+
+        expect(layoutOut.polar.angularaxis.direction).toBe('counterclockwise');
+        expect(layoutOut.polar.angularaxis.rotation).toBe(0);
+
+        _supply({
+            polar: {
+                angularaxis: {direction: 'clockwise'}
+            }
+        });
+
+        expect(layoutOut.polar.angularaxis.direction).toBe('clockwise');
+        expect(layoutOut.polar.angularaxis.rotation).toBe(90);
+    });
 });
 
 describe('Test relayout on polar subplots:', function() {