Merge pull request #1910 from plotly/axes-line-noticklabels-fix

Axes line w/o ticklabels fix

Author: etpinard

src/plots/cartesian/axes.js

@@ -1705,7 +1705,7 @@ axes.doTicks = function(gd, axid, skipTitle) {
         labelShift = ax.ticklen * Math.sin(caRad);
     }
 
-    if(ax.ticks === 'outside' || ax.showline) {
+    if(ax.showticklabels && (ax.ticks === 'outside' || ax.showline)) {
         labelStandoff += 0.2 * ax.tickfont.size;
     }
 

tasks/util/container_commands.js

@@ -59,11 +59,13 @@ function getRunCI(commands) {
     commands = ['export CIRCLECI=1', containerCommands.cdHome].concat(commands);
 
     var commandsJoined = '"' + commands.join(' && ') + '"';
+    var containerId = '$(docker inspect --format \'{{.Id}}\' ' + constants.testContainerName + ')';
 
     return [
         'sudo',
-        'lxc-attach -n',
-        '$(docker inspect --format \'{{.Id}}\' ' + constants.testContainerName + ')',
+        'lxc-attach',
+        '-n', containerId,
+        '-f', '/var/lib/docker/containers/' + containerId + '/config.lxc',
         '-- bash -c',
         commandsJoined
     ].join(' ');

test/image/baselines/axes_line_noticklabels.png

@@ -0,0 +1,18 @@
+{
+  "data": [{
+    "x": [0, 1, 2, 3, 4, 5, 6, 7, 8],
+    "y": [0, 1, 2, 3, 4, 5, 6, 7, 8]
+  }],
+  "layout": {
+    "xaxis": {
+	  "title": "x axis line w/o tick labels",
+      "showline": true,
+      "showticklabels": false
+    },
+    "yaxis": {
+	  "title": "y axis line w/o tick labels",
+      "showline": true,
+      "showticklabels": false
+    }
+  }
+}