5291: make transform update func in fullLayout

Author: alexhartstone

src/components/fx/hover.js

@@ -23,7 +23,6 @@ var Color = require('../color');
 var dragElement = require('../dragelement');
 var Axes = require('../../plots/cartesian/axes');
 var Registry = require('../../registry');
-var plotApi = require('../../plot_api/plot_api');
 
 var helpers = require('./helpers');
 var constants = require('./constants');
@@ -341,7 +340,7 @@ function _hover(gd, evt, subplot, noHoverEvent) {
             xpx = evt.clientX - dbb.left;
             ypx = evt.clientY - dbb.top;
 
-            plotApi.recalculateTransformInverseIfNecessary(gd);
+            fullLayout._recalculateTransformInverseIfNecessary(gd);
             var transformedCoords = Lib.apply3DTransform(fullLayout._inverseTransform)(xpx, ypx);
 
             xpx = transformedCoords[0];

src/plot_api/plot_api.js

@@ -3706,13 +3706,29 @@ function purge(gd) {
     return gd;
 }
 
+// determines if the graph div requires a recalculation of its inverse matrix transforms by comparing old + new bounding boxes.
+function recalculateTransformInverseIfNecessary(gd, newBBox) {
+    gd = Lib.getGraphDiv(gd);
+    var fullLayout = gd._fullLayout;
+    if (!newBBox)
+        newBBox = gd.getBoundingClientRect();
+    if (Lib.domRectsAreEqual(newBBox, fullLayout._lastBBox))
+        return;
+    var m = fullLayout._inverseTransform = Lib.inverseTransformMatrix(Lib.getFullTransformMatrix(gd));
+    fullLayout._inverseScaleX = Math.sqrt(m[0][0] * m[0][0] + m[0][1] * m[0][1] + m[0][2] * m[0][2]);
+    fullLayout._inverseScaleY = Math.sqrt(m[1][0] * m[1][0] + m[1][1] * m[1][1] + m[1][2] * m[1][2]);
+    fullLayout._lastBBox = gd.getBoundingClientRect();
+}
+
 // -------------------------------------------------------
 // makePlotFramework: Create the plot container and axes
 // -------------------------------------------------------
 function makePlotFramework(gd) {
     var gd3 = d3.select(gd);
     var fullLayout = gd._fullLayout;
-    recalculateTransformInverseIfNecessary(gd);
+
+    fullLayout._recalculateTransformInverseIfNecessary = recalculateTransformInverseIfNecessary;
+    fullLayout._recalculateTransformInverseIfNecessary(gd);
 
     // Plot container
     fullLayout._container = gd3.selectAll('.plot-container').data([0]);
@@ -3857,20 +3873,6 @@ function makePlotFramework(gd) {
     gd.emit('plotly_framework');
 }
 
-// determines if the graph div requires a recalculation of its inverse matrix transforms by comparing old + new bounding boxes.
-function recalculateTransformInverseIfNecessary(gd, newBBox = null) {
-    gd = Lib.getGraphDiv(gd);
-    var fullLayout = gd._fullLayout;
-    if (!newBBox)
-        newBBox = gd.getBoundingClientRect();
-    if (Lib.domRectsAreEqual(newBBox, fullLayout._lastBBox))
-        return;
-    var m = fullLayout._inverseTransform = Lib.inverseTransformMatrix(Lib.getFullTransformMatrix(gd));
-    fullLayout._inverseScaleX = Math.sqrt(m[0][0] * m[0][0] + m[0][1] * m[0][1] + m[0][2] * m[0][2]);
-    fullLayout._inverseScaleY = Math.sqrt(m[1][0] * m[1][0] + m[1][1] * m[1][1] + m[1][2] * m[1][2]);
-    fullLayout._lastBBox = gd.getBoundingClientRect();
-}
-
 exports.animate = animate;
 exports.addFrames = addFrames;
 exports.deleteFrames = deleteFrames;
@@ -3898,6 +3900,4 @@ exports._guiRelayout = guiEdit(relayout);
 exports._guiRestyle = guiEdit(restyle);
 exports._guiUpdate = guiEdit(update);
 
-exports.recalculateTransformInverseIfNecessary = recalculateTransformInverseIfNecessary;
-
 exports._storeDirectGUIEdit = _storeDirectGUIEdit;