Merge pull request #57 from plotly/fix-display-modebar

Fix logic for display modebar plot config [fixes #56]

Author: etpinard

src/components/modebar/manage.js

@@ -27,9 +27,11 @@ module.exports = function manageModeBar(gd) {
         context = gd._context,
         modeBar = fullLayout._modeBar;
 
-    if(!context.displayModeBar && modeBar) {
-        modeBar.destroy();
-        delete fullLayout._modeBar;
+    if(!context.displayModeBar) {
+        if(modeBar) {
+            modeBar.destroy();
+            delete fullLayout._modeBar;
+        }
         return;
     }
 

test/jasmine/tests/modebar_test.js

@@ -290,6 +290,14 @@ describe('ModeBar', function() {
         });
 
         it('displays or not mode bar according to displayModeBar config arg', function() {
+            var gd = getMockGraphInfo();
+            gd._context.displayModeBar = false;
+
+            manageModeBar(gd);
+            expect(gd._fullLayout._modeBar).not.toBeDefined();
+        });
+
+        it('updates mode bar according to displayModeBar config arg', function() {
             var gd = getMockGraphInfo();
             manageModeBar(gd);
             expect(gd._fullLayout._modeBar).toBeDefined();