fix rangeslider.y.rangemode=auto and add a test image

Author: alexcjohnson

src/components/rangeslider/defaults.js

@@ -41,7 +41,7 @@ module.exports = function handleDefaults(layoutIn, layoutOut, axName) {
     coerce('borderwidth');
     coerce('thickness');
 
-    coerce('autorange', !axOut.isValidRange(containerIn.range));
+    axOut._rangesliderAutorange = coerce('autorange', !axOut.isValidRange(containerIn.range));
     coerce('range');
 
     var subplots = layoutOut._subplots;
@@ -60,15 +60,18 @@ module.exports = function handleDefaults(layoutIn, layoutOut, axName) {
             var rangeContainerIn = containerIn[yName] || {};
             var rangeContainerOut = containerOut[yName] = {};
 
+            var yAxOut = layoutOut[yName];
+
             var rangemodeDflt;
-            if(rangeContainerIn.range && layoutOut[yName].isValidRange(rangeContainerIn.range)) {
+            if(rangeContainerIn.range && yAxOut.isValidRange(rangeContainerIn.range)) {
                 rangemodeDflt = 'fixed';
             }
 
             var rangeMode = coerceRange(rangeContainerIn, rangeContainerOut, 'rangemode', rangemodeDflt);
             if(rangeMode !== 'match') {
-                coerceRange(rangeContainerIn, rangeContainerOut, 'range', layoutOut[yName].range.slice());
+                coerceRange(rangeContainerIn, rangeContainerOut, 'range', yAxOut.range.slice());
             }
+            yAxOut._rangesliderAutorange = (rangeMode === 'auto');
         }
     }
 

src/plots/cartesian/autorange.js

@@ -211,7 +211,7 @@ function doAutoRange(ax) {
 }
 
 function needsAutorange(ax) {
-    return ax.autorange || !!(ax.rangeslider || {}).autorange;
+    return ax.autorange || ax._rangesliderAutorange;
 }
 
 /*

src/plots/cartesian/axis_defaults.js

@@ -49,6 +49,12 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
 
     var autoRange = coerce('autorange', !containerOut.isValidRange(containerIn.range));
 
+    // both x and y axes may need autorange done just for the range slider's purposes
+    // the logic is complicated to figure this out later, particularly for y axes since
+    // the settings can be spread out in the x axes... so instead we'll collect them
+    // during supplyDefaults
+    containerOut._rangesliderAutorange = false;
+
     if(autoRange) coerce('rangemode');
 
     coerce('range');

test/image/baselines/range_slider_rangemode.png

@@ -0,0 +1,30 @@
+{
+  "data": [
+    {"y": [4, 7e7, 5e5, 6e8, 3e2], "type": "bar"},
+    {"y": [1, 4, 2, 6, 3], "xaxis": "x2", "yaxis": "y2"}
+  ],
+  "layout": {
+    "xaxis": {
+      "domain": [0, 0.42],
+      "range": [1, 3],
+      "rangeslider": {
+        "yaxis": {"rangemode": "auto"}
+      },
+      "title": "Rangeslider Y rangemode auto"
+    },
+    "xaxis2": {
+      "anchor": "y2",
+      "domain": [0.58, 1],
+      "range": [1.5, 3.5],
+      "rangeslider": {
+        "range": [-2, 4],
+        "yaxis2": {"rangemode": "fixed", "range": [0, 10]}
+      },
+      "title": "Rangeslider Y2 rangemode fixed"
+    },
+    "yaxis": {"type": "log", "range": [2, 6], "title": "Y explicit range"},
+    "yaxis2": {"anchor": "x2", "title": "Y2 autoranged"},
+    "width": 700,
+    "height": 500
+  }
+}

test/image/mocks/range_slider_rangemode.json

@@ -1876,7 +1876,7 @@ describe('Test axes', function() {
             data = [2, 5];
 
             ax.autorange = false;
-            ax.rangeslider = { autorange: true };
+            ax._rangesliderAutorange = true;
 
             expand(ax, data, {});
             expect(ax._min).toEqual([{val: 2, pad: 0, extrapad: false}]);