fixups & 🔒 for plotlyServerUrl

Author: etpinard

src/plot_api/plot_config.js

@@ -21,6 +21,10 @@ module.exports = {
     // no interactivity, for export or image generation
     staticPlot: false,
 
+    // base url for the 'Edit in Chart Studio' (aka sendDataToCloud) mode bar button
+    // and the showLink/sendData on-graph link
+    plotlyServerUrl: 'https://plot.ly',
+
     /*
      * we can edit titles, move annotations, etc - sets all pieces of `edits`
      * unless a separate `edits` config item overrides individual parts

src/plots/plots.js

@@ -214,11 +214,7 @@ function positionPlayWithData(gd, container) {
 plots.sendDataToCloud = function(gd) {
     gd.emit('plotly_beforeexport');
 
-    var baseUrl = (
-        (window.PLOTLYENV && window.PLOTLYENV.BASE_URL) ||
-        (gd.framework.getConfig().plotlyServerUrl) ||
-        'https://plot.ly'
-    );
+    var baseUrl = (window.PLOTLYENV || {}).BASE_URL || gd._context.plotlyServerUrl;
 
     var hiddenformDiv = d3.select(gd)
         .append('div')

test/jasmine/tests/config_test.js

@@ -470,7 +470,33 @@ describe('config argument', function() {
             var editBox = document.getElementsByClassName('plugin-editable editable')[0];
             expect(editBox).toBeUndefined();
         });
+    });
+
+    describe('plotlyServerUrl:', function() {
+        var gd;
+
+        beforeEach(function() {
+            gd = createGraphDiv();
+        });
 
+        afterEach(destroyGraphDiv);
 
+        it('should default to plotly cloud', function(done) {
+            Plotly.plot(gd, [], {})
+            .then(function() {
+                expect(gd._context.plotlyServerUrl).toBe('https://plot.ly');
+            })
+            .catch(failTest)
+            .then(done);
+        });
+
+        it('can be set to other base urls', function(done) {
+            Plotly.plot(gd, [], {}, {plotlyServerUrl: 'dummy'})
+            .then(function() {
+                expect(gd._context.plotlyServerUrl).toBe('dummy');
+            })
+            .catch(failTest)
+            .then(done);
+        });
     });
 });