adapt polar to clean-subplots improvements

- use new get-subplot-data tools
- adapt for new offset and selections in Axes.doTicks
- 2018 header

Author: etpinard

lib/scatterpolar.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/lib/angles.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/cartesian/line_grid_defaults.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/domain_attributes.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/plots.js

@@ -2322,9 +2322,8 @@ plots.doCalcdata = function(gd, traces) {
         trace._arrayAttrs = PlotSchema.findArrayAttributes(trace);
     }
 
-    // TODO maybe move this to Axes.list ??
-    // or better yet, make a more general Axes.list
-    var polarIds = plots.getSubplotIds(fullLayout, 'polar');
+    // add polar axes to axis list
+    var polarIds = fullLayout._subplots.polar || [];
     for(i = 0; i < polarIds.length; i++) {
         axList.push(
             fullLayout[polarIds[i]].radialaxis,

src/plots/polar/constants.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/polar/helpers.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/polar/index.js

@@ -8,7 +8,7 @@
 
 'use strict';
 
-var Plots = require('../../plots/plots');
+var getSubplotCalcData = require('../get_data').getSubplotCalcData;
 var counterRegex = require('../../lib').counterRegex;
 
 var createPolar = require('./polar');
@@ -35,11 +35,11 @@ attributes[attr] = {
 function plot(gd) {
     var fullLayout = gd._fullLayout;
     var calcData = gd.calcdata;
-    var subplotIds = Plots.getSubplotIds(fullLayout, name);
+    var subplotIds = fullLayout._subplots[name];
 
     for(var i = 0; i < subplotIds.length; i++) {
         var id = subplotIds[i];
-        var subplotCalcData = Plots.getSubplotCalcData(calcData, name, id);
+        var subplotCalcData = getSubplotCalcData(calcData, name, id);
         var subplot = fullLayout[id]._subplot;
 
         if(!subplot) {
@@ -52,7 +52,7 @@ function plot(gd) {
 }
 
 function clean(newFullData, newFullLayout, oldFullData, oldFullLayout) {
-    var oldIds = Plots.getSubplotIds(oldFullLayout, name);
+    var oldIds = oldFullLayout._subplots[name] || [];
 
     for(var i = 0; i < oldIds.length; i++) {
         var id = oldIds[i];

src/plots/polar/layout_attributes.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the

src/plots/polar/layout_defaults.js

@@ -1,5 +1,5 @@
 /**
-* Copyright 2012-2017, Plotly, Inc.
+* Copyright 2012-2018, Plotly, Inc.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the
@@ -10,9 +10,9 @@
 
 var Lib = require('../../lib');
 var Color = require('../../components/color');
-var Plots = require('../plots');
 var Registry = require('../../registry');
 var handleSubplotDefaults = require('../subplot_defaults');
+var getSubplotData = require('../get_data').getSubplotData;
 
 var handleTickValueDefaults = require('../cartesian/tick_value_defaults');
 var handleTickMarkDefaults = require('../cartesian/tick_mark_defaults');
@@ -35,7 +35,7 @@ function handleDefaults(contIn, contOut, coerce, opts) {
     var sector = coerce('sector');
 
     // could optimize, subplotData is not always needed!
-    var subplotData = Plots.getSubplotData(opts.fullData, constants.name, opts.id);
+    var subplotData = getSubplotData(opts.fullData, constants.name, opts.id);
     var layoutOut = opts.layoutOut;
     var axName;