Rename sliders and bump circular require tolerance

Author: rreusser

src/components/slider/attributes.js renamed to src/components/sliders/attributes.js

@@ -155,7 +155,6 @@ function findDimensions(gd, sliderOpts) {
     sliderOpts.labelStride = Math.max(1, Math.ceil(computedSpacePerLabel / availableSpacePerLabel));
     sliderOpts.labelHeight = labelHeight;
 
-    // Hard-code this for now:
     sliderOpts.height = constants.tickOffset + constants.tickLength + sliderOpts.labelHeight + sliderOpts.ypad * 2;
 
     var xanchor = 'left';
@@ -205,6 +204,8 @@ function drawSlider(gd, sliderGroup, sliderOpts) {
     // Position the rectangle:
     Lib.setTranslate(sliderGroup, sliderOpts.lx + sliderOpts.xpad, sliderOpts.ly + sliderOpts.ypad);
 
+    // Every time the slider is draw from scratch, just detach and reattach the event listeners.
+    // This could perhaps be avoided.
     removeListeners(gd, sliderGroup, sliderOpts);
     attachListeners(gd, sliderGroup, sliderOpts);
 

src/components/slider/constants.js renamed to src/components/sliders/constants.js

@@ -11,7 +11,7 @@
 
 exports.moduleType = 'component';
 
-exports.name = 'slider';
+exports.name = 'sliders';
 
 exports.layoutAttributes = require('./attributes');
 

src/components/slider/defaults.js renamed to src/components/sliders/defaults.js

@@ -58,7 +58,7 @@ exports.register([
     require('./components/shapes'),
     require('./components/images'),
     require('./components/updatemenus'),
-    require('./components/slider'),
+    require('./components/sliders'),
     require('./components/rangeslider'),
     require('./components/rangeselector')
 ]);

src/components/slider/draw.js renamed to src/components/sliders/draw.js

@@ -178,7 +178,7 @@ Plotly.plot = function(gd, data, layout, config) {
         Registry.getComponentMethod('legend', 'draw')(gd);
         Registry.getComponentMethod('rangeselector', 'draw')(gd);
         Registry.getComponentMethod('updatemenus', 'draw')(gd);
-        Registry.getComponentMethod('slider', 'draw')(gd);
+        Registry.getComponentMethod('sliders', 'draw')(gd);
 
         for(i = 0; i < calcdata.length; i++) {
             cd = calcdata[i];
@@ -304,7 +304,7 @@ Plotly.plot = function(gd, data, layout, config) {
         Registry.getComponentMethod('rangeslider', 'draw')(gd);
         Registry.getComponentMethod('rangeselector', 'draw')(gd);
         Registry.getComponentMethod('updatemenus', 'draw')(gd);
-        Registry.getComponentMethod('slider', 'draw')(gd);
+        Registry.getComponentMethod('sliders', 'draw')(gd);
     }
 
     function cleanUp() {
@@ -1946,6 +1946,15 @@ function _relayout(gd, aobj) {
             for(i = 0; i < diff; i++) menus.push({});
             flags.doplot = true;
         }
+        else if(p.parts[0] === 'sliders') {
+            Lib.extendDeepAll(gd.layout, Lib.objectFromPath(ai, vi));
+
+            var sliders = gd._fullLayout.sliders || [];
+            diff = (p.parts[2] + 1) - sliders.length;
+
+            for(i = 0; i < diff; i++) sliders.push({});
+            flags.doplot = true;
+        }
         // alter gd.layout
         else {
             // check whether we can short-circuit a full redraw

src/components/slider/index.js renamed to src/components/sliders/index.js

@@ -37,7 +37,7 @@ exports.Shapes = require('./components/shapes');
 exports.Legend = require('./components/legend');
 exports.Images = require('./components/images');
 exports.UpdateMenus = require('./components/updatemenus');
-exports.Slider = require('./components/slider');
+exports.Sliders = require('./components/sliders');
 exports.ModeBar = require('./components/modebar');
 
 // plot api

src/core.js

@@ -105,7 +105,7 @@ function assertCircularDeps() {
     // as of v1.17.0 - 2016/09/08
     // see https://github.com/plotly/plotly.js/milestone/9
     // for more details
-    var MAX_ALLOWED_CIRCULAR_DEPS = 33;
+    var MAX_ALLOWED_CIRCULAR_DEPS = 34;
 
     if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
         logs.push('some new circular dependencies were added to src/');