warn user if trace index is invalid or out of bounds

also fix attribute in test

Author: antoinerg

src/plot_api/helpers.js

@@ -491,7 +491,15 @@ exports.coerceTraceIndices = function(gd, traceIndices) {
         return gd.data.map(function(_, i) { return i; });
     }
     else if(Array.isArray(traceIndices)) {
-        return traceIndices.filter(function(i) {return i < gd.data.length;});
+        var traceIndicesOut = [];
+        for(var i = 0; i < traceIndices.length; i++) {
+            if(Lib.isIndex(traceIndices[i], gd.data.length)) {
+                traceIndicesOut.push(traceIndices[i]);
+            } else {
+                Lib.warn('trace index (', traceIndices[i], ') is not a number or is out of bounds');
+            }
+        }
+        return traceIndicesOut;
     }
 
     return traceIndices;

test/jasmine/tests/plot_api_test.js

@@ -930,7 +930,7 @@ describe('Test plot api', function() {
             mockDefaultsAndCalc(gd);
 
             // Call restyle on an invalid trace indice
-            Plotly.restyle(gd, {'type': 'scatter', 'marker.color': 'scatter'}, [1]);
+            Plotly.restyle(gd, {'type': 'scatter', 'marker.color': 'red'}, [1]);
         });
 
         it('restores null values to defaults', function() {
@@ -2595,7 +2595,7 @@ describe('Test plot api', function() {
 
         it('ignores invalid trace indices', function() {
             // Call update on an invalid trace indice
-            Plotly.update(gd, {'type': 'scatter', 'marker.color': 'scatter'}, {}, [1]);
+            Plotly.update(gd, {'type': 'scatter', 'marker.color': 'red'}, {}, [1]);
         });
     });