unified hoverlabel: test waterfall symbol

Author: antoinerg

src/components/legend/style.js

@@ -291,7 +291,7 @@ module.exports = function style(s, gd, legend) {
     function styleWaterfalls(d) {
         var trace = d[0].trace;
 
-        if(d[0]._distinct && d[0].trace[d[0].dir]) {
+        if(d[0]._distinct && d[0].dir && trace[d[0].dir] && trace[d[0].dir].marker) {
             var cont = d[0].trace[d[0].dir].marker;
             d[0].mc = cont.color;
             d[0].mlw = cont.line.width;

test/jasmine/tests/hover_label_test.js

@@ -3699,6 +3699,8 @@ describe('hovermode: (x|y)unified', function() {
         var hoverLayer = d3.select('g.hoverlayer');
         var hover = hoverLayer.select('g.legend');
         var traces = hover.selectAll('g.traces');
+        expect(traces.size()).toBe(exp.length);
+
         traces.each(function(d, i) {
             var pts = d3.select(this).selectAll('g.legendpoints path');
             pts.each(function() {
@@ -3923,6 +3925,31 @@ describe('hovermode: (x|y)unified', function() {
             .then(done);
     });
 
+    it('should style waterfall symbols correctly', function(done) {
+        var mock = require('@mocks/waterfall_custom.json');
+        var mockCopy = Lib.extendDeep({}, mock);
+        mockCopy.layout.hovermode = 'x unified';
+        Plotly.newPlot(gd, mockCopy)
+            .then(function(gd) {
+                _hover(gd, {xval: 4});
+                assertSymbol([
+                  ['rgb(255, 65, 54)', '0px', '']
+                ]);
+                return Plotly.restyle(gd, {
+                    'decreasing.marker.line.width': 5,
+                    'decreasing.marker.line.color': 'violet'
+                });
+            })
+            .then(function(gd) {
+                _hover(gd, {xval: 4});
+                assertSymbol([
+                  ['rgb(255, 65, 54)', '5px', 'rgb(238, 130, 238)']
+                ]);
+            })
+            .catch(failTest)
+            .then(done);
+    });
+
     it('label should have color of paper_bgcolor', function(done) {
         var mockCopy = Lib.extendDeep({}, mock);
         var bgcolor = 'rgb(15, 200, 85)';