more strict check for double negative numbers

etpinard · etpinard · commit bac33ab4cd9c · 2018-02-09T09:25:13.000-05:00
diff --git a/test/image/strict-d3.js b/test/image/strict-d3.js
@@ -55,7 +55,7 @@ function checkAttrVal(sel, key, val) {
 
     // make sure no double-negative string get into the DOM,
     // their handling differs from browsers to browsers
-    if(/--/.test(val)) {
+    if(/--/.test(val) && isNumeric(val.split('--')[1].charAt(0))) {
         throw new Error('d3 selection.attr called with value ' + val + ' which includes a double negative');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ function checkAttrVal(sel, key, val) {`
`55`	`55`
`56`	`56`	`// make sure no double-negative string get into the DOM,`
`57`	`57`	`// their handling differs from browsers to browsers`
`58`		`- if(/--/.test(val)) {`
	`58`	`+ if(/--/.test(val) && isNumeric(val.split('--')[1].charAt(0))) {`
`59`	`59`	`throw new Error('d3 selection.attr called with value ' + val + ' which includes a double negative');`
`60`	`60`	`}`
`61`	`61`	`}`