mv zmin/zmax/zauto backward compat mappings in surface defaults:

- so that Plotly.restyle is also kept backward compatible.

Author: etpinard

src/plot_api/plot_api.js

@@ -761,11 +761,6 @@ function cleanData(data, existingData) {
             if(cont.colorscale === 'YIGnBu') cont.colorscale = 'YlGnBu';
             if(cont.colorscale === 'YIOrRd') cont.colorscale = 'YlOrRd';
         }
-        if(Plots.traceIs(trace, 'surface')) {
-            if('zmin' in trace) trace.cmin = trace.zmin;
-            if('zmax' in trace) trace.cmax = trace.zmax;
-            if('zauto' in trace) trace.cauto = trace.zauto;
-        }
 
         // prune empty containers made before the new nestedProperty
         if(emptyContainer(trace, 'line')) delete trace.line;

src/traces/surface/defaults.js

@@ -58,7 +58,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     coerce('hidesurface');
     coerce('opacity');
 
-    coerce('surfacecolor');
+    var surfaceColor = coerce('surfacecolor');
 
     coerce('colorscale');
 
@@ -87,7 +87,20 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         }
     }
 
+    // backward compatibility block
+    if(!surfaceColor) {
+        mapLegacy(traceIn, 'zmin', 'cmin');
+        mapLegacy(traceIn, 'zmax', 'cmax');
+        mapLegacy(traceIn, 'zauto', 'cauto');
+    }
+
     colorscaleDefaults(
         traceIn, traceOut, layout, coerce, {prefix: '', cLetter: 'c'}
     );
 };
+
+function mapLegacy(traceIn, oldAttr, newAttr) {
+    if(oldAttr in traceIn && !(newAttr in traceIn)) {
+        traceIn[newAttr] = traceIn[oldAttr];
+    }
+}