pull transition constants into own file, lower duration to 750ms

Author: etpinard

src/traces/sunburst/constants.js

@@ -0,0 +1,14 @@
+/**
+* Copyright 2012-2019, Plotly, Inc.
+* All rights reserved.
+*
+* This source code is licensed under the MIT license found in the
+* LICENSE file in the root directory of this source tree.
+*/
+
+'use strict';
+
+module.exports = {
+    CLICK_TRANSITION_TIME: 750,
+    CLICK_TRANSITION_EASING: 'linear'
+};

src/traces/sunburst/plot.js

@@ -25,8 +25,7 @@ var transformInsideText = require('../pie/plot').transformInsideText;
 var formatPieValue = require('../pie/helpers').formatPieValue;
 var styleOne = require('./style').styleOne;
 
-var CLICK_TRANSITION_TIME = 1000;
-var CLICK_TRANSITION_EASING = 'linear'; // TODO or something else?
+var constants = require('./constants');
 
 module.exports = function(gd, cdmodule, transitionOpts, makeOnCompleteCallback) {
     var fullLayout = gd._fullLayout;
@@ -682,11 +681,11 @@ function attachFxHandlers(sliceTop, gd, cd) {
         var animOpts = {
             frame: {
                 redraw: false,
-                duration: CLICK_TRANSITION_TIME
+                duration: constants.CLICK_TRANSITION_TIME
             },
             transition: {
-                duration: CLICK_TRANSITION_TIME,
-                easing: CLICK_TRANSITION_EASING
+                duration: constants.CLICK_TRANSITION_TIME,
+                easing: constants.CLICK_TRANSITION_EASING
             },
             mode: 'immediate',
             fromcurrent: true

test/jasmine/tests/sunburst_test.js

@@ -1,6 +1,7 @@
 var Plotly = require('@lib');
 var Plots = require('@src/plots/plots');
 var Lib = require('@src/lib');
+var constants = require('@src/traces/sunburst/constants');
 
 var d3 = require('d3');
 var supplyAllDefaults = require('../assets/supply_defaults');
@@ -888,7 +889,7 @@ describe('Test sunburst tweening:', function() {
         click(gd, v)();
 
         // 1 second more than the click transition duration
-        return delay(1001);
+        return delay(constants.CLICK_TRANSITION_TIME + 1);
     }
 
     function trim(s) {