fix drawing splines

Author: archmoj

src/components/drawing/index.js

@@ -1165,7 +1165,12 @@ function applyBackoff(pt, start) {
     var d = pt.d;
     var i = pt.i;
 
-    if(backoff && trace && trace.marker && trace.marker.angle === 0) {
+    if(backoff && trace &&
+        trace.marker &&
+        trace.marker.angle % 360 === 0 &&
+        trace.line &&
+        trace.line.shape !== 'spline'
+    ) {
         var arrayBackoff = Lib.isArrayOrTypedArray(backoff);
         var end = pt;
 

src/traces/scatter/attributes.js

@@ -306,13 +306,12 @@ module.exports = {
         },
         simplify: {
             valType: 'boolean',
+            dflt: true,
             editType: 'plot',
             description: [
                 'Simplifies lines by removing nearly-collinear points. When transitioning',
                 'lines, it may be desirable to disable this so that the number of points',
-                'along the resulting SVG path is unaffected.',
-                'Defaults to *false* when `backoff` is set,',
-                'otherwise defaults to *true*.'
+                'along the resulting SVG path is unaffected.'
             ].join(' ')
         },
         editType: 'plot'

src/traces/scatter/defaults.js

@@ -42,7 +42,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         handleLineDefaults(traceIn, traceOut, defaultColor, layout, coerce, {backoff: true});
         handleLineShapeDefaults(traceIn, traceOut, coerce);
         coerce('connectgaps');
-        coerce('line.simplify', traceOut.backoff ? false : true);
+        coerce('line.simplify');
     }
 
     if(subTypes.hasMarkers(traceOut)) {

test/image/baselines/scattercarpet-on-two-carpets.png

@@ -56,27 +56,15 @@
             "x": [
                 1,
                 2,
-                null,
-                2,
-                3,
-                null,
                 3,
                 4,
-                null,
-                4,
                 5
             ],
             "y": [
                 6,
                 8,
-                null,
-                8,
-                7,
-                null,
                 7,
                 8,
-                null,
-                8,
                 6
             ]
         },

test/image/baselines/smith_gaps.png

@@ -43322,7 +43322,8 @@
       ]
      },
      "simplify": {
-      "description": "Simplifies lines by removing nearly-collinear points. When transitioning lines, it may be desirable to disable this so that the number of points along the resulting SVG path is unaffected. Defaults to *false* when `backoff` is set, otherwise defaults to *true*.",
+      "description": "Simplifies lines by removing nearly-collinear points. When transitioning lines, it may be desirable to disable this so that the number of points along the resulting SVG path is unaffected.",
+      "dflt": true,
       "editType": "plot",
       "valType": "boolean"
      },