Ignore offsetgroup and alignmentgroup for those trace types that don't have a mode "stack", i.e. scatter, box, violin, waterfall

Author: my-tien

src/traces/box/defaults.js

@@ -303,7 +303,10 @@ function crossTraceDefaults(fullData, fullLayout) {
 
         if(traceType === 'box' || traceType === 'violin') {
             traceIn = traceOut._input;
-            handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, fullLayout[traceType + 'mode']);
+            var mode = fullLayout[traceType + 'mode'];            
+            if(mode === 'group') {
+                handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, mode);
+            }
         }
     }
 }

src/traces/scatter/cross_trace_defaults.js

@@ -7,17 +7,20 @@ var attributes = require('./attributes');
 // remove opacity for any trace that has a fill or is filled to
 module.exports = function crossTraceDefaults(fullData, fullLayout) {
     var traceIn, traceOut, i;
+    var scattermode = fullLayout.scattermode;
 
     function coerce(attr) {
         return Lib.coerce(traceOut._input, traceOut, attributes, attr);
     }
 
-    for(i = 0; i < fullData.length; i++) {
-        traceOut = fullData[i];
-
-        if(traceOut.type === 'scatter') {
-            traceIn = traceOut._input;
-            handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, fullLayout.scattermode);
+    if(fullLayout.scattermode === 'group') {
+        for(i = 0; i < fullData.length; i++) {
+            traceOut = fullData[i];
+    
+            if(traceOut.type === 'scatter') {
+                traceIn = traceOut._input;
+                handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, scattermode);
+            }
         }
     }
 

src/traces/waterfall/defaults.js

@@ -85,12 +85,13 @@ function crossTraceDefaults(fullData, fullLayout) {
     function coerce(attr) {
         return Lib.coerce(traceOut._input, traceOut, attributes, attr);
     }
+    if(fullLayout.waterfallmode === 'group') {
+        for(var i = 0; i < fullData.length; i++) {
+            traceOut = fullData[i];
+            traceIn = traceOut._input;
 
-    for(var i = 0; i < fullData.length; i++) {
-        traceOut = fullData[i];
-        traceIn = traceOut._input;
-
-        handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, fullLayout.waterfallmode);
+            handleGroupingDefaults(traceIn, traceOut, fullLayout, coerce, fullLayout.waterfallmode);
+        }
     }
 }