clear all selection outlines in one place

- during supplyDefaults

Author: etpinard

src/plots/cartesian/index.js

@@ -184,11 +184,6 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)
             oldFullLayout._infolayer.select('.' + axIds[i] + 'title').remove();
         }
     }
-
-    // clean selection
-    if(oldFullLayout._zoomlayer) {
-        oldFullLayout._zoomlayer.selectAll('.select-outline').remove();
-    }
 };
 
 exports.drawFramework = function(gd) {

src/plots/mapbox/mapbox.js

@@ -328,10 +328,6 @@ proto.updateFx = function(fullLayout) {
 
     if(self.isStatic) return;
 
-    function clearSelect() {
-        fullLayout._zoomlayer.selectAll('.select-outline').remove();
-    }
-
     function invert(pxpy) {
         var obj = self.map.unproject(pxpy);
         return [obj.lng, obj.lat];
@@ -376,16 +372,16 @@ proto.updateFx = function(fullLayout) {
         };
 
         dragOptions.doneFn = function(dragged, numClicks) {
-            if(numClicks === 2) clearSelect();
+            if(numClicks === 2) {
+                fullLayout._zoomlayer.selectAll('.select-outline').remove();
+            }
         };
 
         dragElement.init(dragOptions);
     } else {
         map.dragPan.enable();
         self.div.onmousedown = null;
     }
-
-    clearSelect();
 };
 
 proto.updateFramework = function(fullLayout) {

src/plots/plots.js

@@ -624,6 +624,10 @@ plots.cleanPlot = function(newFullData, newFullLayout, oldFullData, oldFullLayou
                 .selectAll(query).remove();
         }
     }
+
+    if(oldFullLayout._zoomlayer) {
+        oldFullLayout._zoomlayer.selectAll('.select-outline').remove();
+    }
 };
 
 plots.linkSubplots = function(newFullData, newFullLayout, oldFullData, oldFullLayout) {

src/plots/ternary/index.js

@@ -69,8 +69,4 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)
             oldTernary.clipDef.remove();
         }
     }
-
-    if(oldFullLayout._zoomlayer) {
-        oldFullLayout._zoomlayer.selectAll('.select-outline').remove();
-    }
 };