Fix bug that prevented update of shape properties

* Added test that updates the layer property of a shape.

Author: n-riesco

src/components/shapes/index.js

@@ -238,7 +238,7 @@ function updateShape(gd, index, opt, value) {
     else if(Lib.isPlainObject(opt)) optionsEdit = opt;
 
     var optionKeys = Object.keys(optionsEdit);
-    for(i = 0; i < optionsEdit.length; i++) {
+    for(i = 0; i < optionKeys.length; i++) {
         var k = optionKeys[i];
         Lib.nestedProperty(optionsIn, k).set(optionsEdit[k]);
     }

test/jasmine/tests/shapes_test.js

@@ -186,5 +186,45 @@ describe('Test shapes:', function() {
                 expect(countShapes(gd)).toEqual(index);
             }).then(done);
         });
+
+        it('should be able to update a shape layer', function(done) {
+            var index = countShapes(gd),
+                astr = 'shapes[' + index + ']',
+                shape = getRandomShape(),
+                shapesInLowerLayer = countShapePathsInLowerLayer(),
+                shapesInUpperLayer = countShapePathsInUpperLayer();
+
+            shape.xref = 'paper';
+            shape.yref = 'paper';
+
+            Plotly.relayout(gd, astr, shape).then(function() {
+                expect(countShapePathsInLowerLayer())
+                    .toEqual(shapesInLowerLayer);
+                expect(countShapePathsInUpperLayer())
+                    .toEqual(shapesInUpperLayer + 1);
+                expect(getLastShape(gd)).toEqual(shape);
+                expect(countShapes(gd)).toEqual(index + 1);
+            }).then(function() {
+                shape.layer = 'below';
+                Plotly.relayout(gd, astr + '.layer', shape.layer);
+            }).then(function() {
+                expect(countShapePathsInLowerLayer())
+                    .toEqual(shapesInLowerLayer + 1);
+                expect(countShapePathsInUpperLayer())
+                    .toEqual(shapesInUpperLayer);
+                expect(getLastShape(gd)).toEqual(shape);
+                expect(countShapes(gd)).toEqual(index + 1);
+            }).then(function() {
+                shape.layer = 'above';
+                Plotly.relayout(gd, astr + '.layer', shape.layer);
+            }).then(function() {
+                expect(countShapePathsInLowerLayer())
+                    .toEqual(shapesInLowerLayer);
+                expect(countShapePathsInUpperLayer())
+                    .toEqual(shapesInUpperLayer + 1);
+                expect(getLastShape(gd)).toEqual(shape);
+                expect(countShapes(gd)).toEqual(index + 1);
+            }).then(done);
+        });
     });
 });