Merge pull request #1557 from hy9be/perf-addLinks

Remove the performance overhead of showLink property

Author: etpinard

src/plots/plots.js

@@ -257,6 +257,9 @@ plots.previousPromises = function(gd) {
  * Add source links to your graph inside the 'showSources' config argument.
  */
 plots.addLinks = function(gd) {
+    // Do not do anything if showLink and showSources are not set to true in config
+    if(!gd._context.showLink && !gd._context.showSources) return;
+
     var fullLayout = gd._fullLayout;
 
     var linkContainer = fullLayout._paper

test/jasmine/tests/config_test.js

@@ -160,11 +160,7 @@ describe('config argument', function() {
 
             var link = document.getElementsByClassName('js-plot-link-container')[0];
 
-            expect(link.textContent).toBe('');
-
-            var bBox = link.getBoundingClientRect();
-            expect(bBox.width).toBe(0);
-            expect(bBox.height).toBe(0);
+            expect(link).toBeUndefined();
         });
 
         it('should display a link when true', function() {