Merge pull request #819 from plotly/mapbox-layer-clear

Skip over non-object mapbox layer containers

Author: etpinard

src/plots/mapbox/layout_defaults.js

@@ -50,9 +50,11 @@ function handleLayerDefaults(containerIn, containerOut) {
     }
 
     for(var i = 0; i < layersIn.length; i++) {
-        layerIn = layersIn[i] || {};
+        layerIn = layersIn[i];
         layerOut = {};
 
+        if(!Lib.isPlainObject(layerIn)) continue;
+
         var sourceType = coerce('sourcetype');
         coerce('source');
 
@@ -86,6 +88,7 @@ function handleLayerDefaults(containerIn, containerOut) {
             coerce('symbol.textposition');
         }
 
+        layerOut._index = i;
         layersOut.push(layerOut);
     }
 }

test/jasmine/tests/mapbox_test.js

@@ -80,6 +80,20 @@ describe('mapbox defaults', function() {
         expect(layoutOut.mapbox.layers[1].sourcetype).toEqual('geojson');
     });
 
+    it('should skip over non-object layer containers', function() {
+        layoutIn = {
+            mapbox: {
+                layers: [{}, null, 'remove', {}]
+            }
+        };
+
+        supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+        expect(layoutOut.mapbox.layers[0].sourcetype).toEqual('geojson');
+        expect(layoutOut.mapbox.layers[0]._index).toEqual(0);
+        expect(layoutOut.mapbox.layers[1].sourcetype).toEqual('geojson');
+        expect(layoutOut.mapbox.layers[1]._index).toEqual(3);
+    });
+
     it('should coerce \'sourcelayer\' only for *vector* \'sourcetype\'', function() {
         layoutIn = {
             mapbox: {