make a similar function in helpers to test x or y hover modes

Author: archmoj

src/components/fx/helpers.js

@@ -239,6 +239,11 @@ function getPointData(val, pointNumber) {
     }
 }
 
+var xyHoverMode = {
+    x: true,
+    y: true
+};
+
 var unifiedHoverMode = {
     'x unified': true,
     'y unified': true
@@ -248,3 +253,8 @@ exports.isUnifiedHover = function(hovermode) {
     if(typeof hovermode !== 'string') return false;
     return !!unifiedHoverMode[hovermode];
 };
+
+exports.isXYhover = function(hovermode) {
+    if(typeof hovermode !== 'string') return false;
+    return !!xyHoverMode[hovermode];
+};

src/components/fx/hover.js

@@ -45,8 +45,6 @@ var YSHIFTY = Math.sin(YA_RADIANS);
 var HOVERARROWSIZE = constants.HOVERARROWSIZE;
 var HOVERTEXTPAD = constants.HOVERTEXTPAD;
 
-var XY = {x: 1, y: 1};
-
 // fx.hover: highlight data on hover
 // evt can be a mousemove event, or an object with data about what points
 //   to hover on
@@ -631,9 +629,10 @@ function _hover(gd, evt, subplot, noHoverEvent) {
     hoverData.sort(function(d1, d2) { return d1.distance - d2.distance; });
 
     // If in compare mode, select every point at position
-    if(hoverData[0].length !== 0 &&
-      XY[mode] &&
-      hoverData[0].trace.type !== 'splom' // TODO: add support for splom
+    if(
+        helpers.isXYhover(mode) &&
+        hoverData[0].length !== 0 &&
+        hoverData[0].trace.type !== 'splom' // TODO: add support for splom
     ) {
         var hd = hoverData[0];
         var cd0 = hd.cd[hd.index];