more upstream fix for avoiding invisible traces

Author: monfera

src/plots/cartesian/select.js

@@ -23,6 +23,11 @@ var MINSELECT = constants.MINSELECT;
 
 function getAxId(ax) { return ax._id; }
 
+function visible(searchInfo) {
+    var cd0 = searchInfo.cd[0];
+    return cd0 && cd0.trace && cd0.trace.visible === true;
+}
+
 module.exports = function prepSelect(e, startX, startY, dragOptions, mode) {
     var zoomLayer = dragOptions.gd._fullLayout._zoomlayer,
         dragBBox = dragOptions.element.getBoundingClientRect(),
@@ -190,6 +195,7 @@ module.exports = function prepSelect(e, startX, startY, dragOptions, mode) {
                 selection = [];
                 for(i = 0; i < searchTraces.length; i++) {
                     searchInfo = searchTraces[i];
+                    if(!visible(searchInfo)) continue;
                     var thisSelection = fillSelectionItem(
                         searchInfo.selectPoints(searchInfo, poly), searchInfo
                     );
@@ -218,6 +224,7 @@ module.exports = function prepSelect(e, startX, startY, dragOptions, mode) {
                 outlines.remove();
                 for(i = 0; i < searchTraces.length; i++) {
                     searchInfo = searchTraces[i];
+                    if(!visible(searchInfo)) continue;
                     searchInfo.selectPoints(searchInfo, false);
                 }
 

src/traces/choropleth/select.js

@@ -46,11 +46,9 @@ module.exports = function selectPoints(searchInfo, polygon) {
         }
     }
 
-    if(node3) {
-        node3.selectAll('path').style('opacity', function(d) {
-            return d.dim ? DESELECTDIM : 1;
-        });
-    }
+    node3.selectAll('path').style('opacity', function(d) {
+        return d.dim ? DESELECTDIM : 1;
+    });
 
     return selection;
 };