Remove default option for titleposition.

If it is undefined, titleposition is set to 'middle center', if hole > 0,
and to 'top center' otherwise. _verifyTitle now returns a promise.

Author: codrut3

src/traces/pie/attributes.js

@@ -197,7 +197,6 @@ module.exports = {
             'middle center',
             'bottom left', 'bottom center', 'bottom right'
         ],
-        dflt: 'top center',
         role: 'info',
         editType: 'calc',
         description: [

src/traces/pie/defaults.js

@@ -70,8 +70,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     var hole = coerce('hole');
     var title = coerce('title');
     if(title) {
-        var titlePosition = coerce('titleposition');
-
+        var titlePosition = coerce('titleposition', hole ? 'middle center' : 'top center');
         if(!hole && titlePosition === 'middle center') traceOut.titleposition = 'top center';
         coerceFont(coerce, 'titlefont', layout.font);
     }

src/traces/pie/plot.js

@@ -582,7 +582,7 @@ function positionTitleOutside(cd0, plotSize) {
 function getTitleSpace(cd0, plotSize) {
     var trace = cd0.trace;
     var pieBoxHeight = plotSize.h * (trace.domain.y[1] - trace.domain.y[0]);
-    // use at most half of the plot for the pie
+    // use at most half of the plot for the title
     return Math.min(cd0.titleBox.height, pieBoxHeight / 2);
 }
 

test/jasmine/tests/pie_test.js

@@ -187,7 +187,6 @@ describe('Pie traces:', function() {
         Plotly.newPlot(gd, [{
             values: [2, 2, 2, 2],
             title: 'Test<br>Title',
-            titleposition: 'middle center',
             hole: 0.5,
             type: 'pie',
             textinfo: 'none'
@@ -243,22 +242,24 @@ describe('Pie traces:', function() {
     });
 
     function _verifyTitle(checkLeft, checkRight, checkTop, checkBottom, checkMiddleX) {
-        var title = d3.selectAll('.titletext text');
-        expect(title.size()).toBe(1);
-        var titleBox = d3.select('g.titletext').node().getBoundingClientRect();
-        var pieBox = d3.select('g.trace').node().getBoundingClientRect();
-        // check that margins agree. we leave an error margin of 2.
-        if(checkLeft) expect(Math.abs(titleBox.left - pieBox.left)).toBeLessThan(2);
-        if(checkRight) expect(Math.abs(titleBox.right - pieBox.right)).toBeLessThan(2);
-        if(checkTop) expect(Math.abs(titleBox.top - pieBox.top)).toBeLessThan(2);
-        if(checkBottom) expect(Math.abs(titleBox.bottom - pieBox.bottom)).toBeLessThan(2);
-        if(checkMiddleX) {
-            expect(Math.abs(titleBox.left + titleBox.right - pieBox.left - pieBox.right))
-                .toBeLessThan(2);
-        }
+        return function() {
+            var title = d3.selectAll('.titletext text');
+            expect(title.size()).toBe(1);
+            var titleBox = d3.select('g.titletext').node().getBoundingClientRect();
+            var pieBox = d3.select('g.trace').node().getBoundingClientRect();
+            // check that margins agree. we leave an error margin of 2.
+            if(checkLeft) expect(Math.abs(titleBox.left - pieBox.left)).toBeLessThan(2);
+            if(checkRight) expect(Math.abs(titleBox.right - pieBox.right)).toBeLessThan(2);
+            if(checkTop) expect(Math.abs(titleBox.top - pieBox.top)).toBeLessThan(2);
+            if(checkBottom) expect(Math.abs(titleBox.bottom - pieBox.bottom)).toBeLessThan(2);
+            if(checkMiddleX) {
+                expect(Math.abs(titleBox.left + titleBox.right - pieBox.left - pieBox.right))
+                    .toBeLessThan(2);
+            }
+        };
     }
 
-    it('shows title top center if there is no hole', function(done) {
+    it('shows title top center if hole is zero', function(done) {
         Plotly.newPlot(gd, [{
             values: [2, 2, 2, 2],
             title: 'Test<BR>Title',
@@ -275,6 +276,21 @@ describe('Pie traces:', function() {
         .then(done);
     });
 
+    it('shows title top center if titleposition is undefined and no hole', function(done) {
+        Plotly.newPlot(gd, [{
+            values: [2, 2, 2, 2],
+            title: 'Test<BR>Title',
+            titlefont: {
+                size: 12
+            },
+            type: 'pie',
+            textinfo: 'none'
+        }], {height: 300, width: 300})
+        .then(_verifyTitle(false, false, true, false, true))
+        .catch(failTest)
+        .then(done);
+    });
+
     it('shows title top center', function(done) {
         Plotly.newPlot(gd, [{
             values: [1, 1, 1, 1, 2],