Merge pull request #3842 from plotly/one-sided-violins-fixes

One-sided violins with set width fixes

Author: etpinard

src/traces/box/cross_trace_calc.js

@@ -133,6 +133,16 @@ function setPositionOffset(traceType, gd, boxList, posAxis) {
         var edge = bPos + bdPos;
         var edgeplus;
         var edgeminus;
+        // value-space padding
+        var vpadplus;
+        var vpadminus;
+        // pixel-space padding
+        var ppadplus;
+        var ppadminus;
+        // do we add 5% of both sides (more logic for points beyond box/violin below)
+        var padded = Boolean(width);
+        // does this trace show points?
+        var hasPts = (trace.boxpoints || trace.points) && (shownPts > 0);
 
         if(side === 'positive') {
             pushplus = dPos * (width ? 1 : 0.5);
@@ -147,17 +157,6 @@ function setPositionOffset(traceType, gd, boxList, posAxis) {
             edgeplus = edgeminus = edge;
         }
 
-        // value-space padding
-        var vpadplus;
-        var vpadminus;
-        // pixel-space padding
-        var ppadplus;
-        var ppadminus;
-        // do we add 5% of both sides (for points beyond box/violin)
-        var padded = false;
-        // does this trace show points?
-        var hasPts = (trace.boxpoints || trace.points) && (shownPts > 0);
-
         if(hasPts) {
             var pointpos = trace.pointpos;
             var jitter = trace.jitter;

src/traces/box/hover.js

@@ -58,6 +58,7 @@ function hoverOnBoxes(pointData, xval, yval, hovermode) {
         hoverPseudoDistance, spikePseudoDistance;
 
     var boxDelta = t.bdPos;
+    var boxDeltaPos, boxDeltaNeg;
     var posAcceptance = t.wHover;
     var shiftPos = function(di) { return di.pos + t.bPos - pVal; };
 
@@ -67,18 +68,23 @@ function hoverOnBoxes(pointData, xval, yval, hovermode) {
                 var pos = shiftPos(di);
                 return Fx.inbox(pos, pos + posAcceptance, hoverPseudoDistance);
             };
+            boxDeltaPos = boxDelta;
+            boxDeltaNeg = 0;
         }
         if(trace.side === 'negative') {
             dPos = function(di) {
                 var pos = shiftPos(di);
                 return Fx.inbox(pos - posAcceptance, pos, hoverPseudoDistance);
             };
+            boxDeltaPos = 0;
+            boxDeltaNeg = boxDelta;
         }
     } else {
         dPos = function(di) {
             var pos = shiftPos(di);
             return Fx.inbox(pos - posAcceptance, pos + posAcceptance, hoverPseudoDistance);
         };
+        boxDeltaPos = boxDeltaNeg = boxDelta;
     }
 
     var dVal;
@@ -134,8 +140,8 @@ function hoverOnBoxes(pointData, xval, yval, hovermode) {
     else if(Color.opacity(mc) && trace.boxpoints) pointData.color = mc;
     else pointData.color = trace.fillcolor;
 
-    pointData[pLetter + '0'] = pAxis.c2p(di.pos + t.bPos - boxDelta, true);
-    pointData[pLetter + '1'] = pAxis.c2p(di.pos + t.bPos + boxDelta, true);
+    pointData[pLetter + '0'] = pAxis.c2p(di.pos + t.bPos - boxDeltaNeg, true);
+    pointData[pLetter + '1'] = pAxis.c2p(di.pos + t.bPos + boxDeltaPos, true);
 
     pointData[pLetter + 'LabelVal'] = di.pos;