review fixes

ckiss · ckiss · commit 8a308a81f34f · 2017-07-05T11:59:13.000+03:00
diff --git a/src/components/fx/attributes.js b/src/components/fx/attributes.js
@@ -38,6 +38,7 @@ module.exports = {
             valType: 'number',
             min: 0,
             dflt: 15,
+            arrayOk: true,
             role: 'style',
             description: 'Sets the length (in number of characters) of the hover labels for this trace'
         }
diff --git a/src/components/fx/hover.js b/src/components/fx/hover.js
@@ -689,7 +689,9 @@ function createHoverText(hoverData, opts, gd) {
             // strip out our pseudo-html elements from d.name (if it exists at all)
             name = svgTextUtils.plainText(d.name || '');
 
-            if(name.length > commonLabelOpts.namelength && commonLabelOpts.namelength > 0) name = name.substr(0, commonLabelOpts.namelength - 3) + '...';
+            if(commonLabelOpts.namelength > 0 && name.length > commonLabelOpts.namelength) {
+                name = name.substr(0, commonLabelOpts.namelength - 3) + '...';
+            }
         }
 
         // used by other modules (initially just ternary) that

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ module.exports = {`
`38`	`38`	`valType: 'number',`
`39`	`39`	`min: 0,`
`40`	`40`	`dflt: 15,`
	`41`	`+ arrayOk: true,`
`41`	`42`	`role: 'style',`
`42`	`43`	`description: 'Sets the length (in number of characters) of the hover labels for this trace'`
`43`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -689,7 +689,9 @@ function createHoverText(hoverData, opts, gd) {`
`689`	`689`	`// strip out our pseudo-html elements from d.name (if it exists at all)`
`690`	`690`	`name = svgTextUtils.plainText(d.name \|\| '');`
`691`	`691`
`692`		`- if(name.length > commonLabelOpts.namelength && commonLabelOpts.namelength > 0) name = name.substr(0, commonLabelOpts.namelength - 3) + '...';`
	`692`	`+ if(commonLabelOpts.namelength > 0 && name.length > commonLabelOpts.namelength) {`
	`693`	`+ name = name.substr(0, commonLabelOpts.namelength - 3) + '...';`
	`694`	`+ }`
`693`	`695`	`}`
`694`	`696`
`695`	`697`	`// used by other modules (initially just ternary) that`