clear selection on zoom/pan

Author: alexcjohnson

src/plots/cartesian/graph_interact.js

@@ -1389,6 +1389,7 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             else if(dragModeNow === 'pan') {
                 dragOptions.moveFn = plotDrag;
                 dragOptions.doneFn = dragDone;
+                clearSelect();
             }
             else if(dragModeNow === 'select' || dragModeNow === 'lasso') {
                 prepSelect(e, startX, startY, dragOptions, dragModeNow);
@@ -1438,9 +1439,17 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
             })
             .attr('d','M0,0Z');
 
+        clearSelect();
         for(i = 0; i < allaxes.length; i++) forceNumbers(allaxes[i].range);
     }
 
+    function clearSelect() {
+        // until we get around to persistent selections, remove the outline
+        // here. The selection itself will be removed when the plot redraws
+        // at the end.
+        plotinfo.plot.selectAll('.select-outline').remove();
+    }
+
     function zoomMove(dx0, dy0) {
         var x1 = Math.max(0, Math.min(pw, dx0 + x0)),
             y1 = Math.max(0, Math.min(ph, dy0 + y0)),

src/plots/cartesian/select.js

@@ -133,16 +133,18 @@ module.exports = function prepSelect(e, startX, startY, dragOptions, mode) {
     };
 
     dragOptions.doneFn = function(dragged, numclicks) {
-        if(!dragged && numclicks === 2) dragOptions.doubleclick();
+        if(!dragged && numclicks === 2) {
+            // clear selection on doubleclick
+            outlines.remove();
+            for(i = 0; i < searchTraces.length; i++) {
+                searchInfo = searchTraces[i];
+                searchInfo.selectPoints(searchInfo, false);
+            }
+        }
         else {
             dragOptions.gd.emit('plotly_selected', eventData);
         }
-        outlines.remove();
         corners.remove();
-        for(i = 0; i < searchTraces.length; i++) {
-            searchInfo = searchTraces[i];
-            searchInfo.selectPoints(searchInfo, false);
-        }
     };
 };